Free ringbuf buffer by relying on gc, not gc_free()#6238
Merged
jepler merged 2 commits intoadafruit:7.2.xfrom Apr 5, 2022
Merged
Free ringbuf buffer by relying on gc, not gc_free()#6238jepler merged 2 commits intoadafruit:7.2.xfrom
jepler merged 2 commits intoadafruit:7.2.xfrom
Conversation
jepler
approved these changes
Apr 5, 2022
jepler
left a comment
There was a problem hiding this comment.
Thanks! If this tests out OK it seems like the simplest and therefore relatively safe fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6213 by not calling gc_free() on the ringbuf buffer, since
ringbuf_free()may be called after the VM has stopped running. Instead, just rely on gc to free the buffer, if the VM is running.Removes the
heapstruct field, since it's no longer needed.This is not related to #6237, even though it seemed that way for a while.