Merged
Conversation
enable IRQ for PDMIn
ladyada
approved these changes
Jan 12, 2022
Member
ladyada
left a comment
There was a problem hiding this comment.
didnt test but.... is there any linter that will warn if irq code is accessing a non-volatile variable? i feel like its such a killer bug that keeps popping up in microcontroller code :/
Collaborator
Author
Totally agree. I looked at the ones in https://github.com/caramelomartins/awesome-linters and also did some general searching; I could not find any checkers, but it would not be so hard as long as IRQ routines were labeled as such. |
jepler
added a commit
that referenced
this pull request
Jan 14, 2022
PDMIn fix for SAMD: backport of #5842
This was referenced Feb 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SAMD PDMIn has not worked right for a while.
volatile, as it should have been.pdmin_reset()was commented out, maybe left over from some debugging.I will probably backport this to 7.1.x, but there is maybe one other unrelated regression that should be checked for a 7.1.1 release first.