Automate USB VID/PID Uniqueness Check#2966
Merged
Merged
Conversation
…t use duplicate USB VID/PID values unless explicitly whitelisted to do so
…t from raising RuntimeError
… ci_check_vid_pid
Member
|
@kattni Did you have a chance to look at this at all? |
|
@tannewt No, not at all. Other things ended up taking priority. |
Member
|
Ok, no problem! Just wanted to make sure the status here was up-to-date. Thanks! |
Member
|
I'm going to do this tomorrow. |
tannewt
approved these changes
Sep 15, 2020
tannewt
left a comment
Member
There was a problem hiding this comment.
Looks great! I've fixed it up to pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2962
I added in my assumptions for ignore-able, whitelisted boards.
I imagine this will sit open a while, during any VID/PID reassignment. I'm more than happy to update
mpconfigboard.mkentries here, or just defer it all to merge in changes prior to merging this one.Example Actions run: https://github.com/sommersoft/circuitpython/runs/714747984?check_suite_focus=true#step:22:1
(Or...the example run in this PR will work too. Not sure what I was thinking... lol)