Fix status DotStar writes: fixes DotStar issues on PyRulers#2102
Merged
Conversation
ladyada
approved these changes
Sep 2, 2019
ladyada
left a comment
Member
There was a problem hiding this comment.
didnt test on hardware, but looks good to me!
Collaborator
Author
|
Tested on PyRuler (two samples), Trinket M0, Itsy M0, and Itsy M4. |
jerryneedell
approved these changes
Sep 2, 2019
Collaborator
There was a problem hiding this comment.
Tested on PyRuler and Gemma_M0 == works on both! Also fixes #2037. Yay! Thanks.
This was referenced Sep 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2064. New batch of DotStars on PyRulers didn't work with old code. Previous DotStars were much more tolerant of non-spec writes.
This should provoke another 4.x release sooner or later. The changes should be merged to master after merging to 4.x.