Remove deprecated Biquad and replace with BlockBiquad#10213
Merged
Conversation
dhalbert
approved these changes
Apr 1, 2025
Collaborator
dhalbert
left a comment
There was a problem hiding this comment.
This looks good to me but I'd appreciate testing and/or a look-over by a synthio user as well. Thanks.
Member
|
I'll try to test it out soon. Did any existing learn guides about synthio refer to these? I think some did. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10061
synthio.Biquadwithsynthio.BlockBiquad(now namedsynthio.Biquad)synthio.Synthesizer.low_pass_filter,synthio.Synthesizer.high_pass_filter, andsynthio.Synthesizer.band_pass_filtersynthio.AnyBiquadfrom documentationbiquad_filter_statehave been moved intosynthio_biquad(biquad_filter_stateis still used for input and output state)These updates have been tested on a Waveshare RP2040-PiZero with the Waveshare WM8960 Audio HAT. I can share test code if needed.
For interest: @dhalbert @gamblor21