Improve BinarySerializers Class#329
Open
RomanPilyushin wants to merge 1 commit intoactivej:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Made:
Introduced Helper Classes to Reduce Redundancy:
SimpleBinarySerializer<T>:SimpleBinarySerializer<T>that implementsBinarySerializer<T>.Encoder<T>andDecoder<T>for itsencodeanddecodemethods.BYTE_SERIALIZER,INT_SERIALIZER,LONG_SERIALIZER,FLOAT_SERIALIZER,DOUBLE_SERIALIZER,UTF8_SERIALIZER,ISO_88591_SERIALIZER) with instances ofSimpleBinarySerializer.SimpleNullableBinarySerializer<T>:SimpleNullableBinarySerializer<T>for handling nullable types.ofNullablemethod for special cases where the codec isUTF8_SERIALIZERorISO_88591_SERIALIZER.Utilized Method References for Simplicity:
BinaryOutput::writeInt,BinaryInput::readInt) when creating instances ofSimpleBinarySerializerandSimpleNullableBinarySerializer.BinaryOutputandBinaryInput.Optimized the Enum Serializer (
ofEnumMethod):E[] constants = enumType.getEnumConstants()) outside of thedecodemethod.CorruptedDataExceptionis thrown.Refactored the
ofNullableMethod:ofNullablemethod by usingSimpleNullableBinarySerializerfor the special cases ofUTF8_SERIALIZERandISO_88591_SERIALIZER.Summary of Benefits: