Skip to content

Enable Pundit authorization with namespaced decorators #7934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rogerkk wants to merge 1 commit into
base: master
Choose a base branch
from
+36 −1
Open

Enable Pundit authorization with namespaced decorators #7934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/active_admin/pundit_adapter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def policy_target(subject)
case subject
when nil then resource
when Class then subject.new
else subject
else undecorate(subject)
end
end

Expand Down Expand Up @@ -118,6 +118,9 @@ def policies
@policies ||= {}
end

def undecorate(subject)
ResourceController::Decorators.undecorate(subject)
end
end

end
32 changes: 32 additions & 0 deletions spec/unit/pundit_adapter_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,38 @@ def resolve
end
end

context "when decorator name contains policy namespace name" do
before do
allow(ActiveAdmin.application).to receive(:pundit_policy_namespace).and_return :foobar
end

class Admin::PostDecorator
attr_reader :object
delegate_missing_to :object

def initialize(object)
@object = object
end

def decorated?
true
end

def model
object
end
end

it "asks Pundit for a policy for the undecorated object" do
policy = DefaultPolicy.new(double, double)
allow(policy).to receive(:show?).and_return(true)

expect(Pundit).to receive(:policy).with(anything, [:foobar, an_instance_of(Post)]).and_return(policy)

auth.authorized?(:read, Admin::PostDecorator.new(Post.new))
end
end

context "when Pundit is unable to find policy scope" do
let(:collection) { double("collection", to_sym: :collection) }
subject(:scope) { auth.scope_collection(collection, :read) }
Expand Down