Remove the pip-install input#1327
Open
gowridurgad wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the recently added pip-install input from actions/setup-python, including its runtime implementation, documentation references, and related e2e workflow coverage.
Changes:
- Removes
pip-installhandling from the action’s TypeScript source andaction.ymlinput schema. - Deletes documentation sections/links describing
pip-install. - Drops e2e workflow jobs that exercised
pip-install, and updates the compileddist/bundles accordingly.
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/setup-python.ts |
Removes the pip-install execution path and the associated @actions/exec usage. |
action.yml |
Deletes the pip-install input from the action interface. |
README.md |
Removes the pip-install link from the README table of contents. |
docs/advanced-usage.md |
Removes the pip-install documentation section and TOC entry. |
dist/setup/index.js |
Updates the generated bundle to remove pip-install logic (and includes additional large bundle churn). |
dist/cache-save/index.js |
Updates the generated post bundle (also includes additional large bundle churn). |
.github/workflows/e2e-cache.yml |
Removes pip-install-specific e2e cache jobs. |
.github/workflows/e2e-cache-freethreaded.yml |
Removes pip-install-specific e2e cache jobs for freethreaded builds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
31
to
33
| default: false | ||
| pip-version: | ||
| description: "Used to specify the version of pip to install with the Python. Supported format: major[.minor][.patch]." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR removes the
pip-installinput added in v6.1.0 (#1201). The input was meant to make installing dependencies easier, but in practice it installs packages into the global Python environment on the runner, which can cause unexpected behaviour with virtual environments and tools likeuv, and the inline dependencies aren't picked up by tools like Dependabot.Related issue:
#1251
Check list: