Skip to content

Enhance cache-dependency-path handling to support files outside the workspace root #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HarithaVattikuti merged 8 commits into from
Jun 25, 2025
Merged

Enhance cache-dependency-path handling to support files outside the workspace root #1128

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f36c837
ehnace cache dependency path handling
aparnajyothi-y Jun 9, 2025
0511a23
logic update
aparnajyothi-y Jun 9, 2025
b641d7d
npm run format-check
aparnajyothi-y Jun 9, 2025
566d40e
update cacheDependencies tests to cover resolved paths and copy edge …
aparnajyothi-y Jun 9, 2025
8ae6b15
check failure fix
aparnajyothi-y Jun 9, 2025
e0348c8
depricate-windows-2019
aparnajyothi-y Jun 18, 2025
6d7172d
refactored the code
aparnajyothi-y Jun 19, 2025
fab5a1e
Check failure fix
aparnajyothi-y Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
npm run format-check
  • Loading branch information
@aparnajyothi-y
aparnajyothi-y committed Jun 9, 2025
commit b641d7d6ce8655f87a51cc211c1cf5a6b88dcb0e
21 changes: 15 additions & 6 deletions __tests__/setup-python.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ describe('cacheDependencies', () => {
mockedCore.getInput.mockReturnValue('nested/deps.lock');

// Simulate file exists by resolving access without error
mockedFsPromises.access.mockImplementation(async (p) => {
mockedFsPromises.access.mockImplementation(async p => {
const pathStr = typeof p === 'string' ? p : p.toString();
if (pathStr === '/github/action/nested/deps.lock') {
return Promise.resolve();
Expand All @@ -62,11 +62,20 @@ describe('cacheDependencies', () => {
const sourcePath = path.resolve('/github/action', 'nested/deps.lock');
const targetPath = path.resolve('/github/workspace', 'nested/deps.lock');

expect(mockedFsPromises.access).toHaveBeenCalledWith(sourcePath, fs.constants.F_OK);
expect(mockedFsPromises.mkdir).toHaveBeenCalledWith(path.dirname(targetPath), {
recursive: true
});
expect(mockedFsPromises.copyFile).toHaveBeenCalledWith(sourcePath, targetPath);
expect(mockedFsPromises.access).toHaveBeenCalledWith(
sourcePath,
fs.constants.F_OK
);
expect(mockedFsPromises.mkdir).toHaveBeenCalledWith(
path.dirname(targetPath),
{
recursive: true
}
);
expect(mockedFsPromises.copyFile).toHaveBeenCalledWith(
sourcePath,
targetPath
);
expect(mockedCore.info).toHaveBeenCalledWith(
`Copied ${sourcePath} to ${targetPath}`
);
Expand Down
Loading