Add JDK cache benchmark scenario - #11
Closed
brunoborges wants to merge 7 commits into
Closed
Conversation
Compare pinned baseline and candidate setup-java commits across isolated cold and warm Microsoft JDK runs, with raw timing and cache-size artifacts. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Temporarily route the registered focused benchmark workflow through the reusable JDK cache benchmark for branch execution. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Remove the temporary branch-dispatch wiring now that JDK cache samples are complete, leaving the reusable benchmark harness intact for retention. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new “JDK cache” benchmark scenario to measure the impact and storage characteristics of cache-jdk in actions/setup-java@main, alongside existing cache-focused scenarios.
Changes:
- Introduces a new
JDK cacheworkflow that runs baseline vs treatment arms (with/withoutcache-jdk) and reports results. - Adds a dedicated report generator (
report-jdk-cache.mjs) plus tests. - Updates README scenario documentation to include JDK cache storage/behavior.
Show a summary per file
| File | Description |
|---|---|
scripts/report-jdk-cache.mjs |
New report generator that parses job timing data, inspects cache entries, and emits Markdown/JSON/CSV summaries for the JDK cache scenario. |
scripts/report-jdk-cache.test.mjs |
New unit tests for parsing, cache selection, cache-key derivation, and per-arm summarization logic. |
README.md |
Documents the new “JDK cache” benchmark scenario and updates cache-storage scope description. |
.github/workflows/jdk-cache.yml |
Adds the workflow that runs the benchmark, generates a report, and uploads artifacts. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 4/4 changed files
- Comments generated: 2
- Review effort level: Lite
Comment on lines
+29
to
+32
| .sort( | ||
| (a, b) => | ||
| Date.parse(b.created_at ?? 0) - Date.parse(a.created_at ?? 0) | ||
| )[0] ?? null |
Comment on lines
+55
to
+59
| gh cache list --limit 10000 --json id,key \ | ||
| --jq '.[] | select(.key | startswith("setup-java-jdk-")) | .id' | | ||
| while read -r cache_id; do | ||
| gh cache delete "$cache_id" | ||
| done |
Retain the stricter seed/read-only implementation while joining the prior benchmark history.\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Collaborator
Author
|
Consolidated into #10, which now contains the same-ref seed/read-only design, reporting, tests, and documentation from this PR while retaining the earlier benchmark history. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.