Skip to content

Migrate Zulu distribution to new metadata API with CRaC support #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nbauma109 wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Migrate Zulu distribution to new metadata API with CRaC support #998

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
78111dc
Initial plan
Claude Apr 3, 2026
a06c8ec
Migrate Zulu distribution to new metadata API with CRaC support
Claude Apr 3, 2026
3f583bc
Fix redundant ternary expression in getAvailableVersions
Claude Apr 4, 2026
48d05a6
Fix P1 issues: Add pagination and correct architecture mapping for Zu…
Claude Apr 4, 2026
bb2f571
Fix codex P1 issues: Remove TCK filter for EA and use aarch64 for ARM64
Claude Apr 4, 2026
d44c72f
Fix test expectations: x64→arch=x64, arm64→arch=aarch64, EA releases …
Copilot Apr 4, 2026
7f63f5d
Fix JetBrains test: mock HttpClient.prototype.head to avoid real netw…
Copilot Apr 4, 2026
3721876
Revert JetBrains test mock: use real network calls now that cloudfron…
Copilot Apr 4, 2026
a7b700f
Minimize diff: remove unnecessary helper methods and inline logic
Claude Apr 4, 2026
f542c1c
Revert "Minimize diff" - restore helper methods per feedback
Claude Apr 4, 2026
3140bcf
Update __tests__/data/zulu-windows.json
nbauma109 Apr 4, 2026
301143a
Address copilot warnings: fix unused abi var, add pagination test, do…
Copilot Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix redundant ternary expression in getAvailableVersions 
Removed unused archParam variable that always returned arch regardless of condition. The new metadata API doesn't use hw_bitness parameter, so arch is used directly.

Agent-Logs-Url: https://github.com/nbauma109/setup-java/sessions/defb7621-9c39-4bcc-a345-2eb4f3447e39

Co-authored-by: nbauma109 <9403560+nbauma109@users.noreply.github.com>
  • Loading branch information
@Claude @nbauma109
Claude and nbauma109 authored Apr 4, 2026
commit 3f583bc86a9b7e856a9b4a07457098f7dedc0951
3 changes: 1 addition & 2 deletions dist/setup/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114787,12 +114787,11 @@ class ZuluDistribution extends base_installer_1.JavaBase {
console.time('Retrieving available versions for Zulu took'); // eslint-disable-line no-console
}
// Map old API parameters to new metadata API parameters
const archParam = hw_bitness === '64' ? arch : arch;
const osParam = this.getOsParam(platform);
const archiveType = this.getArchiveType(extension);
const requestArguments = [
`os=${osParam}`,
`arch=${archParam}`,
`arch=${arch}`,
`archive_type=${archiveType}`,
`java_package_type=${bundleType}`,
`javafx_bundled=${javafx}`,
Expand Down
3 changes: 1 addition & 2 deletions src/distributions/zulu/installer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,13 +113,12 @@ export class ZuluDistribution extends JavaBase {
}

// Map old API parameters to new metadata API parameters
const archParam = hw_bitness === '64' ? arch : arch;
const osParam = this.getOsParam(platform);
const archiveType = this.getArchiveType(extension);

const requestArguments = [
`os=${osParam}`,
`arch=${archParam}`,
`arch=${arch}`,
`archive_type=${archiveType}`,
`java_package_type=${bundleType}`,
`javafx_bundled=${javafx}`,
Expand Down