Skip to content

Upgrade to node 24 #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HarithaVattikuti merged 9 commits into from
Aug 20, 2025
Merged

Upgrade to node 24 #888

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
dc9eba3
Upgrade to node 24
salmanmkc Jul 31, 2025
bb39e34
fix tests
salmanmkc Jul 31, 2025
e987e88
Fix tests and licences
salmanmkc Aug 8, 2025
ec5db35
format
salmanmkc Aug 8, 2025
9f65915
format x2
salmanmkc Aug 8, 2025
4f5bea9
Upgrade Node.js version in workflow files to 24.x
salmanmkc Aug 8, 2025
f60809d
check failure fix
aparnajyothi-y Aug 19, 2025
09fb092
check failures fix
aparnajyothi-y Aug 19, 2025
6d73940
Fix mock platform
HarithaVattikuti Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
format x2
  • Loading branch information
@salmanmkc
salmanmkc committed Aug 8, 2025
commit 9f659154946fe68dcf05006a7e5acf3e15c8980c
4 changes: 3 additions & 1 deletion __tests__/distributors/temurin-installer.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,9 @@ describe('getAvailableVersions', () => {
])(
'defaults to os.arch(): %s mapped to distro arch: %s',
async (osArch: string, distroArch: string) => {
jest.spyOn(os, 'arch').mockReturnValue(osArch as ReturnType<typeof os.arch>);
jest
.spyOn(os, 'arch')
.mockReturnValue(osArch as ReturnType<typeof os.arch>);
Copy link

Copilot AI Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mock is using osArch but should be using distroArch to match the test parameter. This inconsistency could cause the test to not properly validate the architecture mapping.

Copilot uses AI. Check for mistakes.

const installerOptions: JavaInstallerOptions = {
version: '17',
Expand Down
4 changes: 3 additions & 1 deletion __tests__/distributors/zulu-installer.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,9 @@ describe('getAvailableVersions', () => {
])(
'defaults to os.arch(): %s mapped to distro arch: %s',
async (osArch: string, distroArch: DistroArch) => {
jest.spyOn(os, 'arch').mockReturnValue(osArch as ReturnType<typeof os.arch>);
jest
.spyOn(os, 'arch')
.mockReturnValue(osArch as ReturnType<typeof os.arch>);

const distribution = new ZuluDistribution({
version: '17',
Expand Down
4 changes: 3 additions & 1 deletion __tests__/distributors/zulu-linux-installer.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,9 @@ describe('getAvailableVersions', () => {
])(
'defaults to os.arch(): %s mapped to distro arch: %s',
async (osArch: string, distroArch: DistroArch) => {
jest.spyOn(os, 'arch').mockReturnValue(osArch as ReturnType<typeof os.arch>);
jest
.spyOn(os, 'arch')
.mockReturnValue(osArch as ReturnType<typeof os.arch>);

const distribution = new ZuluDistribution({
version: '17',
Expand Down
4 changes: 3 additions & 1 deletion __tests__/distributors/zulu-windows-installer.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,9 @@ describe('getAvailableVersions', () => {
])(
'defaults to os.arch(): %s mapped to distro arch: %s',
async (osArch: string, distroArch: DistroArch) => {
jest.spyOn(os, 'arch').mockReturnValue(osArch as ReturnType<typeof os.arch>);
jest
.spyOn(os, 'arch')
.mockReturnValue(osArch as ReturnType<typeof os.arch>);

const distribution = new ZuluDistribution({
version: '17',
Expand Down
Loading