Fix failing GitHub Actions job for graalvm 24-ea - #1227
Merged
Conversation
Co-authored-by: brunoborges <129743+brunoborges@users.noreply.github.com>
brunoborges
marked this pull request as ready for review
August 7, 2026 03:17
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the E2E verification script to correctly validate early-access (EA) GraalVM Java versions where setup-java outputs a concrete EA version (e.g. 24.0.0-ea.35) but java -version reports only the major version (e.g. java version "24"), which previously caused the graalvm 24-ea (jdk-x64) - ubuntu-latest job to fail.
Changes:
- Normalize
SETUP_JAVA_VERSIONfor EA builds to the major version (mirroring the existing normalization for the expected input version). - Prevent false failures when comparing
setup-java’s version output againstjava -versionfor EA GraalVM installs.
Show a summary per file
| File | Description |
|---|---|
__tests__/verify-java.sh |
Adjusts version-output verification for *-ea* versions by matching on major version to align with GraalVM’s java -version output format. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.