Skip to content

feat: Disable interactiveMode in generated Maven settings.xml#1052

Open
Copilot wants to merge 2 commits into
mainfrom
copilot/disable-interactivemode-settings-xml
Open

feat: Disable interactiveMode in generated Maven settings.xml#1052
Copilot wants to merge 2 commits into
mainfrom
copilot/disable-interactivemode-settings-xml

Conversation

Copilot AI commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Description:
The Maven settings.xml generated by this action now includes <interactiveMode>false</interactiveMode> by default. This enables batch (non-interactive) mode, so Maven never blocks waiting for user input in CI — equivalent to passing -B/--batch-mode on every invocation.

Note: interactiveMode only controls whether Maven prompts for user input. It does not suppress transfer/download progress output — use -ntp / --no-transfer-progress for that.

Changes:

  • src/auth.ts: Add interactiveMode: false to the settings XML object in generate(), ordered before servers per the Maven settings schema.
  • __tests__/auth.test.ts: Update expected output for the minimal and additional-configuration cases.
  • docs/advanced-usage.md: Update the example settings.xml snippets.
  • dist/: Rebuild bundled action.

Generated output:

<settings xmlns="http://maven.apache.org/SETTINGS/1.0.0"
  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
  xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0 https://maven.apache.org/xsd/settings-1.0.0.xsd">
  <interactiveMode>false</interactiveMode>
  <servers>
    ...
  </servers>
</settings>

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

Copilot AI changed the title [WIP] Update maven settings.xml to disable interactive mode Disable interactiveMode in generated Maven settings.xml Jun 23, 2026
Copilot AI requested a review from brunoborges June 23, 2026 02:06
@brunoborges brunoborges marked this pull request as ready for review June 23, 2026 02:08
@brunoborges brunoborges requested a review from a team as a code owner June 23, 2026 02:08
Copilot AI review requested due to automatic review settings June 23, 2026 02:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Maven settings.xml generated by actions/setup-java to set <interactiveMode>false</interactiveMode> by default, making Maven non-interactive without requiring additional flags in workflow steps.

Changes:

  • Add interactiveMode: false to the generated Maven settings object.
  • Update Jest expected XML snapshots to include the new element.
  • Update documentation settings.xml examples and rebuild the bundled dist/ output.
Show a summary per file
File Description
src/auth.ts Adds interactiveMode: false to the generated Maven settings.xml.
__tests__/auth.test.ts Updates expected XML output in settings generation tests.
docs/advanced-usage.md Updates example settings.xml snippets to include <interactiveMode>false</interactiveMode>.
dist/setup/index.js Updates the bundled distribution to reflect the source change.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 3/4 changed files
  • Comments generated: 1

Comment thread src/auth.ts
@brunoborges brunoborges added feature request New feature or request to improve the current logic maven Maven settings, toolchains, and publishing auth labels Jun 23, 2026
@brunoborges brunoborges requested a review from a team June 23, 2026 02:22
@brunoborges brunoborges requested a review from gdams June 23, 2026 02:30
@brunoborges brunoborges changed the title Disable interactiveMode in generated Maven settings.xml feat: Disable interactiveMode in generated Maven settings.xml Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature request New feature or request to improve the current logic maven Maven settings, toolchains, and publishing auth

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants