feat: Disable interactiveMode in generated Maven settings.xml#1052
Open
Copilot wants to merge 2 commits into
Open
feat: Disable interactiveMode in generated Maven settings.xml#1052Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Update maven settings.xml to disable interactive mode
Disable interactiveMode in generated Maven settings.xml
Jun 23, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Maven settings.xml generated by actions/setup-java to set <interactiveMode>false</interactiveMode> by default, making Maven non-interactive without requiring additional flags in workflow steps.
Changes:
- Add
interactiveMode: falseto the generated Maven settings object. - Update Jest expected XML snapshots to include the new element.
- Update documentation
settings.xmlexamples and rebuild the bundleddist/output.
Show a summary per file
| File | Description |
|---|---|
src/auth.ts |
Adds interactiveMode: false to the generated Maven settings.xml. |
__tests__/auth.test.ts |
Updates expected XML output in settings generation tests. |
docs/advanced-usage.md |
Updates example settings.xml snippets to include <interactiveMode>false</interactiveMode>. |
dist/setup/index.js |
Updates the bundled distribution to reflect the source change. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/4 changed files
- Comments generated: 1
brunoborges
approved these changes
Jun 23, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The Maven
settings.xmlgenerated by this action now includes<interactiveMode>false</interactiveMode>by default. This enables batch (non-interactive) mode, so Maven never blocks waiting for user input in CI — equivalent to passing-B/--batch-modeon every invocation.Changes:
src/auth.ts: AddinteractiveMode: falseto the settings XML object ingenerate(), ordered beforeserversper the Maven settings schema.__tests__/auth.test.ts: Update expected output for the minimal and additional-configuration cases.docs/advanced-usage.md: Update the examplesettings.xmlsnippets.dist/: Rebuild bundled action.Generated output:
Check list: