Rework replacement function for installer to use the same pattern like windows#22
Merged
Merged
Conversation
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vsafonkin
approved these changes
May 5, 2020
al-cheb
approved these changes
May 5, 2020
AlenaSviridenko
approved these changes
May 5, 2020
MaksimZhukov
approved these changes
May 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework creation of installer for Nix platform to use
{{__VERSION_MAJOR__}}pattern (the same like Windows) instead of$installationTemplateContent -f $this.Version.Major, $this.Version.Minor, $this.Version.Buildbecause it prevents to use${variable}in sh scripts and replacement fails with errorError formatting a string: Input string was not in a correct format.