Repository navigation
test: omit stack traces from snapshots - #401
Merged
parkerbxyz merged 2 commits intoOct 12, 2026
Merged
Conversation
Run each test with `--stack-trace-limit=0` so error output no longer includes stack traces. Node.js internal frames changed between versions, which broke 10 snapshots without any change to the action. Without stack traces, the path, line, and color normalization is no longer needed. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: b91f96b7-a7f3-4ff3-8f52-3a617307ede2
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: b91f96b7-a7f3-4ff3-8f52-3a617307ede2
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused changes correctly remove version-sensitive stack frames without weakening error-output or coverage checks.
0 open findings
What changed in this PR
Stabilizes integration snapshots across supported Node.js versions by omitting stack traces while preserving error details.
Changes:
- Runs test processes with
--stack-trace-limit=0. - Removes obsolete stderr normalization and updates affected snapshots.
| File | Description |
|---|---|
tests/index.js |
Disables stack traces in test subprocesses. |
tests/index.js.snapshot |
Updates expected stderr output. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
parkerbxyz
enabled auto-merge (squash)
October 12, 2026 22:35
parkerbxyz
disabled auto-merge
October 12, 2026 22:35
parkerbxyz
deleted the
parkerbxyz-omit-stack-traces-from-test-snapshots
branch
October 12, 2026 22:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
integrationcheck fails onmainbecause 10 snapshots include Node.js internal stack frames, and their names changed between Node.js versions. CI installs the latest Node.js that matches>=24.4.0, so these snapshots can break without any change to the action.This PR runs each test with
--stack-trace-limit=0, so error output no longer includes stack traces. Snapshots still capture the error message, any HTTP error details, and the::error::output users see. Code coverage is still enforced byc8 --100.Without stack traces,
normalizeStderris no longer needed, so this removes it.All 120 tests pass with 100% coverage on Node.js 24 and 26.