Modify subdomain sorting#38
Merged
aboul3la merged 1 commit intoaboul3la:masterfrom Oct 4, 2016
jeremyn:modify_subdomain_sorting
Merged
Modify subdomain sorting#38aboul3la merged 1 commit intoaboul3la:masterfrom jeremyn:modify_subdomain_sorting
aboul3la merged 1 commit intoaboul3la:masterfrom
jeremyn:modify_subdomain_sorting
Conversation
Owner
|
Thanks @jeremyn for your PR. I'm glad to know that Sublist3r would be helpful for you to build the rulesets. I'm a big fan of HTTPS Everywhere and i use it myself. So it's a pleasure to support it :) I really like this type of sorting. It's much better. So I just merged your Pull Request Thanks again and keep up the great work! |
Contributor
Author
|
Awesome, thank you! |
This was referenced Oct 4, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm a ruleset reviewer for https://github.com/EFForg/https-everywhere , which is a browser add-on that rewrites some HTTP URLs to HTTPS while the user is browsing. Part of creating rules for HTTPS Everywhere is finding subdomains for a particular root domain. Sublist3r looks like a good tool for this, for example see the discussion in EFForg/https-everywhere#6912 , but we have a particular sort order we like subdomains to have in our ruleset files.
This pull request changes the sort order of the displayed subdomains to match our preferred sort order. You can test it by running the below script in the main
Sublist3rdirectory.If you want to allow this change but want to hide it behind an optional flag instead of changing the default behavior, or you want tests or style changes, please let me know. Thanks.