Skip to content

Fixes for PyPI publishing (already published)#57

Merged
mattheworiordan merged 2 commits into
ably:masterfrom
vintasoftware:pypi
Mar 10, 2016
Merged

Fixes for PyPI publishing (already published)#57
mattheworiordan merged 2 commits into
ably:masterfrom
vintasoftware:pypi

Conversation

@fjsj

@fjsj fjsj commented Mar 9, 2016

Copy link
Copy Markdown
Contributor

Comment thread setup.py Outdated
setup(
name='ably',
version='0.1.dev',
version='0.0.2',

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 0.0.2? Is this our version number? If so, it should be 0.8.0 and we need to add a tag v0.8.0 to the Git repo here on Github as well, @fjsj can you do that?

@mattheworiordan

Copy link
Copy Markdown
Member

Thanks @fjsj, one comment re: the version and the need for a tag, see https://github.com/ably/ably-ruby/releases and https://github.com/ably/ably-java/releases for examples

@fjsj

fjsj commented Mar 10, 2016

Copy link
Copy Markdown
Contributor Author

@mattheworiordan fixed the version number. Will make the tag as soon this is merged.

mattheworiordan added a commit that referenced this pull request Mar 10, 2016
Fixes for PyPI publishing (already published)
@mattheworiordan mattheworiordan merged commit 865493a into ably:master Mar 10, 2016
@mattheworiordan

Copy link
Copy Markdown
Member

Thanks @fjsj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants