Conversation
Additional: changes some existing text for better consistancy and a more fluent Dutch translation. Also fixed some typos.
Proper translation of prefIntroCaptions
…tion Update Dutch translation
Also eslint fixes
Also eslint fixes
Also use "e" instead of "_" for ignored caught errors
Caught with eslint. At least, they look like bugs. Hopefully the buggy behavior wasn't important.
Also eslint
This keeps with our allowing unused principle, and also fits better, Vimeo does document these as "events"
Looks like various elements used to get passed around differently, but the old references are still present, just unused or always undefined. Get rid of 'em.
Also eslint
More accurate link name.
7 additional unused strings.
The large input validation test is obsolete, as Able Player rejects input greater than 1000 characters as of 4.8.0. - Reduce the size of largeInput - Catch the thrown Error and test response. - Adds increased timeout on validate test run.
Avoids duplicate logic.
This is only ever used horizontally, so lets simplify a bit.
These are always set to specific static values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains all of the changes for Able Player 5.0 RC1.