Skip to content

Merge main into gh-pages #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joedolson merged 30 commits into from
Sep 18, 2025
Merged

Merge main into gh-pages #684

Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
f48b0e1
Merge pull request #665 from ableplayer/main
joedolson Aug 11, 2025
8276147
Both slower and faster SVG should have same viewBox
joedolson Aug 12, 2025
dff4377
Merge branch 'develop' of https://github.com/ableplayer/ableplayer in…
joedolson Aug 12, 2025
5ce7938
Typos
joedolson Aug 12, 2025
14f73ae
Bug fix: Didn't handle case where player was Youtube and Sign was local.
joedolson Aug 14, 2025
4415775
Improve logic for identifying appropriate sign src.
joedolson Aug 14, 2025
3244629
Adjust min-height of captions/description container
joedolson Aug 31, 2025
8c3d183
Give big play button a partially transparent background.
joedolson Aug 31, 2025
4746d2e
Move colors to inherited variables.
joedolson Aug 31, 2025
089783f
Missing wrapper on playlist 1 demo
joedolson Aug 31, 2025
ba70559
Update URLs, URL indices, move urls for contributing to contribution.
joedolson Aug 31, 2025
2194da2
Add issue and PR templates.
joedolson Sep 2, 2025
c99ac08
fix for regex in the postprocessCTag function
jeanem Sep 4, 2025
4785eca
Merge pull request #679 from jeanem/post-processing-fix
joedolson Sep 5, 2025
03915e2
Remove some unused variables.
joedolson Sep 5, 2025
acdbb7c
Add headings for individual demos
joedolson Sep 5, 2025
083683f
Remove fixed width and height on big play button
joedolson Sep 5, 2025
73894a1
toggleButtonState logic was backwards, resulting in reversed triggers.
joedolson Sep 5, 2025
9b5abec
Description button state is always set at init, and doesn't need to b…
joedolson Sep 5, 2025
d868d92
Check for sign language source checked media object instead of source.
joedolson Sep 5, 2025
c98859c
The volume popup is `.able-volume-slider`, not popup.
joedolson Sep 5, 2025
e09ea94
Update inline documentation about the play and playing events
joedolson Sep 6, 2025
198a5d7
Don't refresh controls on the 'play' event.
joedolson Sep 6, 2025
bd4be73
Why is this here?
joedolson Sep 6, 2025
679394f
Volume option is requested in syncSignVideo, but not used.
joedolson Sep 6, 2025
4edf90c
Improved comment
joedolson Sep 6, 2025
2c84971
If JSON translations not found, look for old version before erroring.
joedolson Sep 18, 2025
e79652d
Note that this demo uses images instead of svgs.
joedolson Sep 18, 2025
ef7f2ab
Update built packages
joedolson Sep 18, 2025
e4f9ea6
Merge pull request #683 from ableplayer/develop
joedolson Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Typos
  • Loading branch information
@joedolson
joedolson committed Aug 12, 2025
commit 5ce793824d561ad9872d1a008302591e5804d044
4 changes: 2 additions & 2 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
- New default theme with modernized layout and variables for colors.
- This summarizes a large number of individually small changes to the layour of AblePlayer elements.
- Removed many instances of positioning imposed from JS so that more positioning is controllable from CSS.
- Significant improvements to responsive desgin and behaviors.
- Significant improvements to responsive design and behaviors.

### Features

Expand Down Expand Up @@ -56,7 +56,7 @@
- Simplify if/else statements. Use ternary or swithc where appropriate or collapse arguments.
- Reformat if/else statements to remove line breaks before `else`.
- Remove `$ableColumnLeft` - unused and unidentified variable.
- Remove unneeed -moz and -mix prefixed fullscreen properties.
- Remove unneeded -moz and -mix prefixed fullscreen properties.
- Only create a single alertBox container and move in DOM as needed instead of managing three separate containers.
- Add new prototype to set the text for buttons.
- Add new prototype to set icons for buttons.
Expand Down