Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
58 commits
Select commit Hold shift + click to select a range
c103f75
Change default skin to "2020"
terrill Nov 11, 2022
f576704
Remove data-skin="2020" attribs from all demos
terrill Nov 11, 2022
9dc0013
[CLEANUP] TABs & colors
xerc Nov 20, 2022
5e1adce
[REMOVE] IE rules
xerc Nov 20, 2022
02c8428
[CLS] 9dc0013
xerc Nov 20, 2022
ff01b78
[CLEANUP] indentation @ `vimeo.js`
xerc Nov 20, 2022
a9af6f6
[CLEANUP] scripts/
xerc Nov 20, 2022
ac5f507
[FIX] VIMEO usage
xerc Nov 26, 2022
ad9f60a
[ADD] noreferrer @ credits-links
xerc Nov 26, 2022
53c91b7
[CLEANUP] more indentation
xerc Nov 26, 2022
d442e83
[CLEANUP] even more ident/tabs
xerc Nov 26, 2022
4346cf5
Added https: to dependencies
candideu Dec 7, 2022
fab3bd5
Too -> to
candideu Dec 7, 2022
7e9cad3
Merge pull request #1 from candideu/main
candideu Dec 7, 2022
4e3ab2e
Merge pull request #561 from candideu/develop
terrill Dec 8, 2022
45c8815
Merge branch 'patch-1' of https://github.com/xerc/ableplayer into xer…
terrill Dec 8, 2022
1df2a2f
Merge branch 'xerc-patch-1' into develop
terrill Dec 8, 2022
d657a71
Merge pull request #557 from xerc/patch-2
terrill Dec 8, 2022
28a99d7
Merge pull request #558 from xerc/patch-3
terrill Dec 8, 2022
c6b95db
Increment version
terrill Dec 8, 2022
abb33b7
Handle failure of Safari on Mac OS to getVoices for speechSynthesis
terrill Dec 11, 2022
f3f095e
Added a screenshot of the player
candideu Mar 24, 2023
60b0c0a
Improve speech initialization for Linux browsers
jbylsma Apr 11, 2023
10385d3
Merge branch 'jbylsma-improve-speech-support' into develop
terrill May 24, 2023
c11e0d8
Merge pull request #573 from candideu/patch-1
terrill May 24, 2023
480456f
Add YouTube (no captions) demo
terrill Jun 13, 2023
85c1fc4
Merge branch 'develop' of github.com:ableplayer/ableplayer into develop
terrill Jun 13, 2023
d7286b1
revert typo from early 2021
conorom Jul 24, 2023
6c41745
Add polish translation
zwiastunsw Mar 14, 2024
43fbd77
resolve problems
zwiastunsw Mar 16, 2024
2c9a4f3
fix typo
zwiastunsw Mar 26, 2024
e129d08
merge main into develop with 4.5.1 patch
jeanem Mar 7, 2025
e551e94
updating current develop version
jeanem Mar 7, 2025
f4a4430
Merge branch 'main' into develop
jeanem Mar 14, 2025
28f7d59
update to develop version
jeanem Mar 21, 2025
3c860a0
Merge pull request #595 from lepszyweb/polish-translation
joedolson May 4, 2025
2cb3f6a
Merge pull request #583 from conorom/571/geteferences_typo
joedolson May 4, 2025
f3662ab
Change 'lead developer' to 'original lead developer'.
joedolson May 6, 2025
4f15b20
Change copyright to Able Player Contributors
joedolson May 6, 2025
6b008e6
The translations object has these camel-cased with 'screen' as a sepa…
joedolson May 24, 2025
ec804b0
Replace deprecated `.click()` with `.trigger( 'click' );`
joedolson May 24, 2025
cbc6d33
Replace deprecated .focus() in demos
joedolson May 24, 2025
7316ecf
Replace jquery `.focus()` with `.trigger( 'focus' )`
joedolson May 24, 2025
af166de
Replace .click() in demos.
joedolson May 25, 2025
e55c22c
Replace .click() with .on( 'click'
joedolson May 25, 2025
63e1a82
Replace instances of $.trim() with .trim()
joedolson May 25, 2025
b1d05bb
Replace .change() with .on( 'change'
joedolson May 25, 2025
e7fa7d3
Replace .keydown with .on( 'keydown'
joedolson May 25, 2025
69caf80
Use 'inert' to change interactivity state of non-modal content.
joedolson May 25, 2025
6f682d0
Replace jQuery isNumeric with vanilla JS numeric check.
joedolson May 25, 2025
913eb71
typeof needs to compare to a string, not a var.
joedolson May 25, 2025
a82fa2a
Firefox no longer requires the orient attribute or the slider-vertica…
joedolson May 25, 2025
3c3bf47
Switch to lr to keep previous appearance.
joedolson May 25, 2025
e2bd655
Remove the `role` and `aria-label` on transcript containers if they a…
joedolson May 25, 2025
6521b22
When fullscreen on narrow screens, using vw caption units is too small.
joedolson May 25, 2025
7b6a59e
Remove console.log
joedolson May 25, 2025
176fdb8
Update PR 575
joedolson May 25, 2025
dac86c7
Merge branch 'main' into fix-unbind-click-event
joedolson Jun 15, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[CLEANUP] even more ident/tabs
  • Loading branch information
xerc committed Nov 26, 2022
commit d442e839c92a7ff3e8ad4ea9d8f2bf93d45dae50
38 changes: 19 additions & 19 deletions scripts/browser.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,29 +33,29 @@
AblePlayer.prototype.browserSupportsVolume = function() {

// To test whether the browser supports changing the volume,
// create a new audio element and try setting the volume to something other than 1.
// Then, retrieve the current setting to see if it preserved it.
// create a new audio element and try setting the volume to something other than 1.
// Then, retrieve the current setting to see if it preserved it.

// Unfortunately, this doesn't work in iOS. In 2022, our tests yield the same results as reported here:
// https://stackoverflow.com/questions/72861253/how-do-i-detect-if-a-browser-does-not-support-changing-html-audio-volume
// Unfortunately, this doesn't work in iOS. In 2022, our tests yield the same results as reported here:
// https://stackoverflow.com/questions/72861253/how-do-i-detect-if-a-browser-does-not-support-changing-html-audio-volume

// So, unfortunately we have to resort to sniffing for iOS
// before testing for support in other browsers
var audio, testVolume;
// So, unfortunately we have to resort to sniffing for iOS
// before testing for support in other browsers
var audio, testVolume;

if (this.isIOS()) {
return false;
}
if (this.isIOS()) {
return false;
}

testVolume = 0.9; // any value between 0.1 and 0.9
audio = new Audio();
audio.volume = testVolume;
if (audio.volume === testVolume) {
return true;
}
else {
return false;
}
testVolume = 0.9; // any value between 0.1 and 0.9
audio = new Audio();
audio.volume = testVolume;
if (audio.volume === testVolume) {
return true;
}
else {
return false;
}
};

AblePlayer.prototype.nativeFullscreenSupported = function () {
Expand Down
20 changes: 10 additions & 10 deletions scripts/buildplayer.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,16 @@

// create and inject surrounding HTML structure
// If IOS:
// If video:
// IOS does not support any of the player's functionality
// - everything plays in its own player
// Therefore, AblePlayer is not loaded & all functionality is disabled
// (this all determined. If this is IOS && video, this function is never called)
// If audio:
// HTML cannot be injected as a *parent* of the <audio> element
// It is therefore injected *after* the <audio> element
// This is only a problem in IOS 6 and earlier,
// & is a known bug, fixed in IOS 7
// If video:
// IOS does not support any of the player's functionality
// - everything plays in its own player
// Therefore, AblePlayer is not loaded & all functionality is disabled
// (this all determined. If this is IOS && video, this function is never called)
// If audio:
// HTML cannot be injected as a *parent* of the <audio> element
// It is therefore injected *after* the <audio> element
// This is only a problem in IOS 6 and earlier,
// & is a known bug, fixed in IOS 7

var thisObj, captionsContainer, prefsGroups, i;
thisObj = this;
Expand Down
12 changes: 6 additions & 6 deletions scripts/control.js
Original file line number Diff line number Diff line change
Expand Up @@ -198,11 +198,11 @@
AblePlayer.prototype.getPlayerState = function () {

// Returns one of the following states:
// 'stopped' - Not yet played for the first time, or otherwise reset to unplayed.
// 'ended' - Finished playing.
// 'paused' - Not playing, but not stopped or ended.
// 'buffering' - Momentarily paused to load, but will resume once data is loaded.
// 'playing' - Currently playing.
// - 'stopped' - Not yet played for the first time, or otherwise reset to unplayed.
// - 'ended' - Finished playing.
// - 'paused' - Not playing, but not stopped or ended.
// - 'buffering' - Momentarily paused to load, but will resume once data is loaded.
// - 'playing' - Currently playing.

// Commented out the following in 3.2.1 - not sure of its intended purpose
// It can be useful to know player state even when swapping src
Expand Down Expand Up @@ -551,7 +551,7 @@
// Only update the aria live region if we have an update pending
// (from a seek button control) or if the seekBar has focus.
// We use document.activeElement instead of $(':focus') due to a strange bug:
// When the seekHead element is focused, .is(':focus') is failing and $(':focus') is returning an undefined element.
// When the seekHead element is focused, .is(':focus') is failing and $(':focus') is returning an undefined element.
updateLive = this.liveUpdatePending || this.seekBar.seekHead.is($(document.activeElement));
this.liveUpdatePending = false;
if (this.useChapterTimes) {
Expand Down
4 changes: 2 additions & 2 deletions scripts/description.js
Original file line number Diff line number Diff line change
Expand Up @@ -674,8 +674,8 @@
// and typically requires a computer reboot to make right again.
// This has been observed frequently in macOS Big Sur, but also in Windows 10
// To ignore user's voice preferences and always use the first voice, set the following var to true
// This is for testing only; not recommended for production
// unless the voice select field is also removed from the Prefs dialog
// This is for testing only; not recommended for production
// unless the voice select field is also removed from the Prefs dialog
var useFirstVoice = false;

if (!this.speechEnabled) {
Expand Down
2 changes: 1 addition & 1 deletion scripts/initialize.js
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@
};

// Initialize player based on data on page.
// This sets some variables, but does not modify anything. Safe to call multiple times.
// This sets some variables, but does not modify anything. Safe to call multiple times.
// Can call again after updating this.media so long as new media element has the same ID.
AblePlayer.prototype.reinitialize = function () {

Expand Down
4 changes: 2 additions & 2 deletions scripts/misc.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@

// Takes seconds and converts to string of form hh:mm:ss
// If showFullTime is true, shows 00 for hours if time is less than an hour
// and show milliseconds (e.g., 00:00:04.123 as in Video Track Sorter)
// and show milliseconds (e.g., 00:00:04.123 as in Video Track Sorter)
// Otherwise, omits empty hours and milliseconds (e.g., 00:04 as in timer on controller)

var dHours, dMinutes, dSeconds,
Expand Down Expand Up @@ -155,7 +155,7 @@
var attr = object.attr(attribute);

// For some browsers, `attr` is undefined; for others,
// `attr` is false. Check for both.
// `attr` is false. Check for both.
if (typeof attr !== typeof undefined && attr !== false) {
return true;
}
Expand Down
8 changes: 4 additions & 4 deletions scripts/slider.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@


// Events:
// startTracking(event, position)
// tracking(event, position)
// stopTracking(event, position)
// - startTracking(event, position)
// - tracking(event, position)
// - stopTracking(event, position)

window. AccessibleSlider = function(mediaType, div, orientation, length, min, max, bigInterval, label, className, trackingMedia, initialState) {

Expand Down Expand Up @@ -322,7 +322,7 @@
this.updateAriaValues(position, updateLive);
}

// TODO: Native HTML5 can have several buffered segments, and this actually happens quite often. Change this to display them all.
// TODO: Native HTML5 can have several buffered segments, and this actually happens quite often. Change this to display them all.
AccessibleSlider.prototype.setBuffered = function (ratio) {
if (!isNaN(ratio)) {
this.buffered = ratio;
Expand Down