Closed
Conversation
Codecov ReportBase: 94.73% // Head: 94.73% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #562 +/- ##
=======================================
Coverage 94.73% 94.73%
=======================================
Files 62 62
Lines 5681 5681
Branches 767 767
=======================================
Hits 5382 5382
Misses 182 182
Partials 117 117 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mypy complains due to the new enum, so the code must be converted to the new style an pyside6 pinned to min 6.4.0
|
Kudos, SonarCloud Quality Gate passed!
|
Owner
Author
|
Superseded by #581 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The old-style enums now break mypy (https://www.qt.io/blog/qt-for-python-release-6.4-is-finally-here), so code had to be updated.
This is postponed until:
Checklist
blackandisort)mypyreturns no errorpytestsucceedshelpreference.rstmake clean && make htmlindocs/)