Skip to content

test: sync mypy command in GEMINI.md with CI#733

Merged
holtskinner merged 1 commit into
mainfrom
ishymko/gemini-md-mypy
Feb 23, 2026
Merged

test: sync mypy command in GEMINI.md with CI#733
holtskinner merged 1 commit into
mainfrom
ishymko/gemini-md-mypy

Conversation

@ishymko

@ishymko ishymko commented Feb 23, 2026

Copy link
Copy Markdown
Member

In CI we don't run mypy on tests, so in order to prevent model from encountering old issues specify the same command as in CI.

In [CI](https://github.com/a2aproject/a2a-python/blob/3ad2503107dd1faa71ab6b56da9017141e24e34c/.github/workflows/linter.yaml#L41) we don't run mypy on tests, so in order to prevent model from encountering old issues specify the same command as in CI.
@ishymko ishymko marked this pull request as ready for review February 23, 2026 16:22
@ishymko ishymko requested a review from a team as a code owner February 23, 2026 16:22
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @ishymko, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request synchronizes the mypy command specified in the GEMINI.md documentation with the actual command executed in the CI pipeline. This ensures that developers follow the correct type-checking procedure, preventing potential issues that might arise from running mypy on test files, which are explicitly excluded in CI.

Highlights

  • Documentation Update: The mypy command in GEMINI.md has been updated to uv run mypy src to align with the command used in the continuous integration (CI) pipeline.
Changelog
  • GEMINI.md
    • Updated the mypy command to uv run mypy src to match CI configuration.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the mypy command in GEMINI.md to uv run mypy src, aligning it with the project's CI configuration. This change correctly scopes type checking to the src directory, which is consistent with other tool configurations like pyright. The update improves consistency between the local development environment and CI, and the documentation change is clear and correct.

@ishymko ishymko enabled auto-merge (squash) February 23, 2026 16:23
@holtskinner holtskinner changed the title docs: sync mypy command in GEMINI.md with CI test: sync mypy command in GEMINI.md with CI Feb 23, 2026
auto-merge was automatically disabled February 23, 2026 16:27

Branch protection rule check failed

@holtskinner holtskinner merged commit cced34d into main Feb 23, 2026
11 checks passed
@holtskinner holtskinner deleted the ishymko/gemini-md-mypy branch February 23, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants