chore(pyproject.toml): change license to text#265
Conversation
`pip show a2a-sdk` was including the whole license file. Changed to just the license name
There was a problem hiding this comment.
Summary of Changes
Hello @zeroasterisk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request refines the package metadata in pyproject.toml to improve how the a2a-sdk package's license information is presented and to enhance its searchability. The primary intent is to streamline the output of pip show by providing the license name directly rather than embedding the full license file, alongside adding a new keyword for better discoverability.
Highlights
- License Metadata Update: The
licensefield inpyproject.tomlhas been updated to directly specify the license name (Apache 2.0) usingtext = "Apache 2.0"instead of referencing theLICENSEfile. This change aims to preventpip showfrom including the entire license file in its output, making the package information more concise. - Keyword Expansion: The
keywordslist inpyproject.tomlhas been expanded to include "Agent 2 Agent", enhancing the package's discoverability through additional search terms.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request aims to change how the project license is specified in pyproject.toml to prevent embedding the full license text when inspecting the package. The change to the keywords is fine. However, the modification to the license field, while functional, does not adhere to the PEP 621 standard. I've suggested a more compliant way to specify the license using its SPDX identifier.
pip show a2a-sdkwas including the whole license file.Changed to just the license name