Skip to content

test: update Middleware test types#260

Merged
holtskinner merged 4 commits into
a2aproject:mainfrom
paulchen5:update-test-types
Jul 1, 2025
Merged

test: update Middleware test types#260
holtskinner merged 4 commits into
a2aproject:mainfrom
paulchen5:update-test-types

Conversation

@paulchen5

@paulchen5 paulchen5 commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

Description

Replace the following:

params={
    'message': {
        'messageId': 'msg1',
        'role': 'user',
        'parts': [],
    }
}

by this:

params=MessageSendParams(
    message=Message(
        messageId='msg1',
        role=Role.user,
        parts=[],
    )
)

@paulchen5 paulchen5 requested a review from a team as a code owner July 1, 2025 05:11
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jul 1, 2025
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @paulchen5, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refactoring existing test cases to utilize structured Python objects for message parameters instead of raw dictionaries. This change aims to improve the maintainability, readability, and type safety of the test suite by aligning parameter passing with defined data models.

Highlights

  • Test Code Refactoring: Replaced dictionary-based message parameters with explicit MessageSendParams and Message objects in send_message calls within test functions, enhancing type safety and readability.
  • Improved Test Clarity: Standardized the way message parameters are passed in tests by leveraging dedicated data structures (Message, MessageSendParams, Role), making test fixtures more robust and easier to understand.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jul 1, 2025
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors tests in tests/client/test_auth_middleware.py to use strongly-typed Pydantic models for request parameters instead of dictionaries. This is a great improvement for type safety and readability. The changes are well-implemented and correct. I've added one suggestion to further improve maintainability by reducing code duplication across the test functions.

Comment thread tests/client/test_auth_middleware.py
@paulchen5 paulchen5 changed the title refactor: ppdate test types refactor: update test types Jul 1, 2025
@holtskinner holtskinner changed the title refactor: update test types test: update Middleware test types Jul 1, 2025
@holtskinner holtskinner merged commit 84eaf83 into a2aproject:main Jul 1, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@holtskinner holtskinner holtskinner approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@paulchen5 @holtskinner