fix(grpc): correct error code mapping and enforce A2A-Version validation - #1167
Open
avilleroy51 wants to merge 2 commits into
Open
fix(grpc): correct error code mapping and enforce A2A-Version validation#1167avilleroy51 wants to merge 2 commits into
avilleroy51 wants to merge 2 commits into
Conversation
🧪 Code Coverage (vs
|
| Base | PR | Delta | |
|---|---|---|---|
| src/a2a/server/request_handlers/grpc_handler.py | 95.42% | 89.20% | 🔴 -6.22% |
| Total | 93.00% | 92.88% | 🔴 -0.12% |
Generated by coverage-comment.yml
Three gRPC error mappings diverged from specification.md:1178-1192 (the normative error-code table): PushNotificationNotSupportedError, UnsupportedOperationError and VersionNotSupportedError were mapped to FAILED_PRECONDITION instead of UNIMPLEMENTED. Separately, the gRPC transport never validated the A2A-Version header at all — DefaultGrpcServerCallContextBuilder.build() didn't expose invocation metadata to the rest of the request-handling code, unlike the JSON-RPC/REST dispatchers which already enforce this via @validate_version. This adds state['headers'] (mirroring the HTTP route builders) and a single _validate_a2a_version() check applied at the one point all 11 RPC methods funnel through, replicating the semantics of validate_version (missing header treated as '0.3'; major version must match). Fixes a2aproject#1166
avilleroy51
force-pushed
the
fix/grpc-error-mapping-and-version-validation
branch
from
August 6, 2026 18:09
f9c0293 to
998b675
Compare
Author
|
Hi maintainers — checking in on this PR. It looks like no CI workflow has run yet on this commit (no check-suites registered), which is expected for a first-time external contributor — GitHub requires a maintainer to approve running workflows on fork PRs. Could someone please approve the workflow run (or take a look) when you have a moment? Happy to address any feedback. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1166 — two bugs in the gRPC transport, found while cross-checking
grpc_handler.pyagainstspecification.md's normative error-code table and against the version-validation behavior already enforced on JSON-RPC/REST.PushNotificationNotSupportedError,UnsupportedOperationErrorandVersionNotSupportedErrorwere mapped toFAILED_PRECONDITIONin_ERROR_CODE_MAP. Perspecification.md:1178-1192(the normative A2A-error → gRPC-status table) all three should map toUNIMPLEMENTED.A2A-Versionnever validated on gRPC. JSON-RPC and REST dispatchers already enforce version compatibility via@validate_version(PROTOCOL_VERSION_1_0). The gRPC transport had no equivalent —DefaultGrpcServerCallContextBuilder.build()never exposedinvocation_metadata()to the rest of the request-handling code, so there was no way for any check to see the caller's declared version. This addsstate['headers'](same shape the HTTP route builders already populate) and a single_validate_a2a_version()check applied where all 11 RPC methods funnel through_build_call_context, replicatingvalidate_version's semantics (missing header ⇒ treated as0.3; major version must match1.0).Test plan
tests/server/request_handlers/test_grpc_handler.pyalone: 43/43 passedtests/integration,tests/install_smoke,tests/compat— out of scope — and modules with pre-existing, unrelatedModuleNotFoundError:respx,opentelemetry, migrations): 997 passed, 0 failedruff checkon both changed files: all checks passedmock_grpc_contextfixture now defaultsinvocation_metadata.return_valuetoa2a-version: 1.0(same conventionTestClient(..., headers={'A2A-Version': '1.0'})already uses for JSON-RPC/REST tests)test_abort_context_error_mappingcases that asserted the oldFAILED_PRECONDITIONmapping updated toUNIMPLEMENTEDTestGrpcExtensionscases that overrideinvocation_metadataupdated to include('a2a-version', '1.0')