Skip to content

docs: clarify EventQueue usage#1066

Open
ishymko wants to merge 2 commits into
mainfrom
ishymko/event-queue-docs-update
Open

docs: clarify EventQueue usage#1066
ishymko wants to merge 2 commits into
mainfrom
ishymko/event-queue-docs-update

Conversation

@ishymko
Copy link
Copy Markdown
Member

@ishymko ishymko commented May 15, 2026

Fix the comment left from the previous version.

Fixes #1064.

@ishymko ishymko requested a review from a team as a code owner May 15, 2026 14:28
@ishymko ishymko requested a review from sokoliva May 15, 2026 14:28
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 15, 2026

🧪 Code Coverage (vs main)

⬇️ Download Full Report

Base PR Delta
src/a2a/server/events/event_queue.py 91.01% 90.00% 🔴 -1.01%
Total 93.08% 93.07% 🔴 -0.01%

Generated by coverage-comment.yml

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the EventQueue class to serve as a producer-side interface and deprecates its direct instantiation by adding a DeprecationWarning in the __new__ method. A review comment points out that because EventQueue is an abstract base class with abstract methods, the redirection logic in __new__ is currently unreachable as the interpreter will raise a TypeError before the method executes. The reviewer suggests removing the @abstractmethod decorators and using NotImplementedError instead to allow the backward compatibility logic to function as intended.

Comment thread src/a2a/server/events/event_queue.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Type-clean EventQueue successor: abstract base makes EventQueue() unusable for mypy users

1 participant