docs: clarify EventQueue usage#1066
Open
ishymko wants to merge 2 commits into
Open
Conversation
🧪 Code Coverage (vs
|
| Base | PR | Delta | |
|---|---|---|---|
| src/a2a/server/events/event_queue.py | 91.01% | 90.00% | 🔴 -1.01% |
| Total | 93.08% | 93.07% | 🔴 -0.01% |
Generated by coverage-comment.yml
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the EventQueue class to serve as a producer-side interface and deprecates its direct instantiation by adding a DeprecationWarning in the __new__ method. A review comment points out that because EventQueue is an abstract base class with abstract methods, the redirection logic in __new__ is currently unreachable as the interpreter will raise a TypeError before the method executes. The reviewer suggests removing the @abstractmethod decorators and using NotImplementedError instead to allow the backward compatibility logic to function as intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the comment left from the previous version.
Fixes #1064.