chore: fix repository url in package.json#98
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @swapydapy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a metadata correction within the project's package.json file, ensuring the repository information is accurate and explicitly defined for package consumers.
Highlights
- Repository URL Correction: The
repositoryfield inpackage.jsonhas been updated to point to the correct GitHub organization and repository URL (a2aproject/a2a-js). - Metadata Format Update: The
repositoryfield's format was changed from a simple string to an object, explicitly defining thetypeasgitand theurlfor better metadata clarity and adherence to commonpackage.jsonpractices.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request correctly updates the repository URL in package.json to point to the new a2aproject organization and uses the more explicit object format. My review includes a suggestion to align the URL format with the official npm documentation for better standards compliance. As a follow-up, you may also want to update other URLs in the project that still point to the old google-a2a organization (e.g., in README.md and the generate script in package.json) to ensure consistency.
| "repository": "google-a2a/a2a-js.git", | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "git+https://github.com/a2aproject/a2a-js.git" |
There was a problem hiding this comment.
While git+ is widely understood by npm, the official package.json documentation for the repository field shows the URL without this prefix. For better standards compliance and to ensure compatibility with a wider range of tools that might parse package.json, it's recommended to use the plain HTTPS URL.
"url": "https://github.com/a2aproject/a2a-js.git"
No description provided.