Skip to content

fix: Bom verification needs to take Windows into account#907

Merged
kabir merged 2 commits into
a2aproject:mainfrom
kabir:windows-ci
Jun 2, 2026
Merged

fix: Bom verification needs to take Windows into account#907
kabir merged 2 commits into
a2aproject:mainfrom
kabir:windows-ci

Conversation

@kabir

@kabir kabir commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

Enhance CI to run Windows build/tests on JDK 17

Enhance CI to run Windows build/tests on JDK 17

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces path normalization using a new helper method toForwardSlash in DynamicBomVerifier.java to ensure cross-platform compatibility when filtering Java source files. The reviewer suggested a more robust and performant approach: relativizing the path first and then performing both the directory and filter checks on the normalized relative path, which prevents potential false positives if the absolute project root path contains /src/main/java/.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread boms/test-utils/src/main/java/org/a2aproject/sdk/bom/test/DynamicBomVerifier.java Outdated
@kabir kabir merged commit 32c5324 into a2aproject:main Jun 2, 2026
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant