fix: Bom verification needs to take Windows into account#907
Conversation
Enhance CI to run Windows build/tests on JDK 17
There was a problem hiding this comment.
Code Review
This pull request introduces path normalization using a new helper method toForwardSlash in DynamicBomVerifier.java to ensure cross-platform compatibility when filtering Java source files. The reviewer suggested a more robust and performant approach: relativizing the path first and then performing both the directory and filter checks on the normalized relative path, which prevents potential false positives if the absolute project root path contains /src/main/java/.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Enhance CI to run Windows build/tests on JDK 17