Repository navigation
feat(opentelemetry): add push notification tracing with CLIENT spans - #1228
Merged
Merged
Conversation
Add OpenTelemetryPushNotificationSenderDecorator that wraps PushNotificationSender to create a CLIENT span for every push delivery. The span carries task_id, context_id, push_notification.event_kind, and optional response payload attributes, with error.type on delivery failure. Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
kabir
requested changes
Oct 16, 2026
|
|
||
| Span span = spanBuilder.startSpan(); | ||
| try (Scope scope = span.makeCurrent()) { | ||
| delegate.sendNotification(event, taskSnapshot); |
Collaborator
There was a problem hiding this comment.
- P1 — Failed push deliveries are recorded as successful. OpenTelemetryPushNotificationSenderDecorator.java:95 sets StatusCode.OK whenever BasePushNotificationSender.sendNotification() returns. That sender catches transport, validation, serialization, and formatter failures, converts them to false, logs them, and returns normally. As a result, real webhook failures produce an OK span with no error.type, contrary to the PR description. Have the sender expose delivery outcome or move tracing around each actual dispatch result.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add OpenTelemetryPushNotificationSenderDecorator that wraps PushNotificationSender to create a CLIENT span for every push delivery. The span carries task_id, context_id, push_notification.event_kind, and optional response payload attributes, with error.type on delivery failure.
Fixes #1217 🦕