Skip to content

feat: Added run name for pdm lock action to easily view it#633

Merged
ritwik-g merged 1 commit into
mainfrom
feat/minor-action-name-added
Aug 29, 2024
Merged

feat: Added run name for pdm lock action to easily view it#633
ritwik-g merged 1 commit into
mainfrom
feat/minor-action-name-added

Conversation

@chandrasekharan-zipstack
Copy link
Copy Markdown
Contributor

@chandrasekharan-zipstack chandrasekharan-zipstack commented Aug 29, 2024 •
edited
Loading

What

  • Added run name to easily view the service being worked with

Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)

  • No

Notes on Testing

  • Checked by triggering manually

Screenshots

Before
image

After
image

Checklist

I have read and understood the Contribution Guidelines.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 29, 2024

filepath function $$\textcolor{#23d18b}{\tt{passed}}$$ SUBTOTAL
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_logs}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_cleanup}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_cleanup\_skip}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_client\_init}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_image\_exists}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_image}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_container\_run\_config}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_container\_run\_config\_without\_mount}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_run\_container}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{TOTAL}}$$ $$\textcolor{#23d18b}{\tt{9}}$$ $$\textcolor{#23d18b}{\tt{9}}$$

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Aug 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

kirtimanmishrazipstack
kirtimanmishrazipstack approved these changes Aug 29, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@kirtimanmishrazipstack kirtimanmishrazipstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ritwik-g
ritwik-g reviewed Aug 29, 2024
View reviewed changes
Comment thread .github/workflows/pdm-lock-automation.yaml
@ritwik-g ritwik-g merged commit 167d426 into main Aug 29, 2024
@ritwik-g ritwik-g deleted the feat/minor-action-name-added branch August 29, 2024 08:15
pk-zipstack pushed a commit that referenced this pull request Aug 20, 2025
@chandrasekharan-zipstack
feat: Added run name for pdm lock action to easily view it (#633)
8ff1500 
Added run name for pdm lock action to easily view it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Deepak-Kesavan Deepak-Kesavan Deepak-Kesavan approved these changes

@ritwik-g ritwik-g ritwik-g approved these changes

@kirtimanmishrazipstack kirtimanmishrazipstack kirtimanmishrazipstack approved these changes

Assignees

@chandrasekharan-zipstack chandrasekharan-zipstack

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chandrasekharan-zipstack @Deepak-Kesavan @ritwik-g @kirtimanmishrazipstack