Treat MiniMax M2 thinking as always on - #2238
Open
octo-patch wants to merge 2 commits into
Open
Conversation
Contributor
|
| Filename | Overview |
|---|---|
| unstract/sdk1/src/unstract/sdk1/adapters/base1.py | Centralizes MiniMax thinking normalization and removes the materialized null thinking field from M2 validation output. |
| unstract/sdk1/src/unstract/sdk1/adapters/llm1/static/minimax.json | Constrains M2-family configurations to explicit enabled thinking across the supported model identifier forms. |
| unstract/sdk1/tests/test_branded_openai_adapters.py | Covers omitted, explicitly enabled, configurable, boundary, casing, and provider-prefixed M2 behavior. |
Reviews (2): Last reviewed commit: "Align MiniMax M2 thinking validation" | Re-trigger Greptile
|
Contributor
Author
|
Thanks for the review. Commit a235538 now omits the thinking parameter for MiniMax M2 requests and aligns schema matching with runtime handling. I ran 64 adapter tests plus Ruff format and lint checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason: Align MiniMax-M2.7 requests with its always-on thinking contract.
Checks:
uv run --project unstract/sdk1 --locked ruff check --ignore I001 unstract/sdk1/src/unstract/sdk1/adapters/base1.py unstract/sdk1/tests/test_branded_openai_adapters.pyuv run --project unstract/sdk1 --locked ruff format --check unstract/sdk1/src/unstract/sdk1/adapters/base1.py unstract/sdk1/tests/test_branded_openai_adapters.pyuv run --project unstract/sdk1 --locked pytest -q unstract/sdk1/tests/test_branded_openai_adapters.py -k 'minimax_m2 or minimax_schema_covers'git diff --check