Skip to content

UN-3741 [FIX] Keep list-row owner and updated columns aligned across rows#2193

Open
athul-rs wants to merge 2 commits into
mainfrom
UN-3741-list-align-followup
Open

UN-3741 [FIX] Keep list-row owner and updated columns aligned across rows#2193
athul-rs wants to merge 2 commits into
mainfrom
UN-3741-list-align-followup

Conversation

@athul-rs

@athul-rs athul-rs commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

What

Keeps the Owned By and Updated columns of the shared list rows at the same
x position on every row, and bolds the list title to match the agentic Prompt
Studio project list.

Why

QA on staging (rc.384) reported two issues on the adapter and Prompt Studio
list pages:

  1. the owner column drifts sideways from row to row
  2. project / adapter names read noticeably thinner than the agentic project list

(1) is a regression from #2182. That PR replaced the row's fixed-width columns
(.list-view-content{width:80%} + .adapters-list-title-container{width:50%})
with a flex layout. The meta cluster is anchored on the row's right edge — the
left column grows to absorb the row's slack — so a content-sized owner column
starts wherever its own text ends up: x=985 for a long email, x=1207 for Me.

(2) is not a regression: .adapters-list-title has never carried a
font-weight, while the agentic list sets 600 on its own title class. The two
lists only look inconsistent when compared side by side.

How

Three CSS rules in the shared ListView:

  • .adapters-list-profile-containerflex: 0 0 240px (avatar + label + the
    200px-capped email), left-aligned so the label starts at a fixed x
  • .list-view-modified-containerflex: 0 0 170px (fits the longest string,
    Updated a few seconds ago)
  • .list-view-metaflex: 0 0 auto so the wrapper cannot shrink below its
    now-rigid children and spill them over the action icons. The left column
    absorbs the shortfall instead — it ellipsizes, this doesn't.

Widths are pinned per sub-column rather than on the wrapper, so pages that show
the owner but no Updated (Connectors, Workflows) reserve no dead space.

Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)

CSS-only, scoped to the four pages that use the shared ListView (adapters via
Tool Settings, Prompt Studio, Connectors, Workflows). No JSX, no props, no API.

The risk worth naming: the two fixed column widths are magic numbers. If a
future column is added to the meta cluster, or the owner label stops being
capped at 200px, they need revisiting. Verified on a deployed build that the
row never overflows, the action icons are never clipped or overlapped, and the
title/owner fall back to their existing ellipsis + tooltip.

Database Migrations

None.

Env Config

None.

Relevant Docs

None.

Related Issues or PRs

Follow-up to #2182.

Dependencies Versions

None.

Notes on Testing

Verified against a deployed build in a dev namespace, measuring live geometry
rather than eyeballing. Rows were stress-varied (short Me, long email, Me +1
co-owner, 50-char service account, mixed relative times, mixed/absent
descriptions).

x-position spread across rows (0 = perfectly aligned):

1920 1440 1024
Owned By 0 0 0
Updated 0 0 0
Updated right edge vs actions left edge -24px -24px -24px
children overflowing the meta box 0 0 0

With the fix reverted in-page, the owner spread returns to 181-222px, which is
the reported bug.

Also checked: no row overflow or clipped action icons down to 1024; the left
column degrades 645 -> 188px through the existing title ellipsis; owner-only
pages collapse the meta cluster to exactly 240px; over-long owner labels
ellipsize at the 200px cap with the full value still in the tooltip.

Not covered: no automated test — this is layout CSS and the repo has no visual
regression harness. Connectors and Workflows were exercised by removing the
Updated block from a live page rather than with real rows, since the test org
has none.

Screenshots

image

Checklist

I have read and understood the Contribution Guidelines.

athul-rs and others added 2 commits July 22, 2026 12:17
The meta cluster is anchored on the row's right edge, so content-sized
columns shifted "Owned By" sideways row by row depending on the length of
the owner label. Pin the owner and updated columns; bold the title to match
the agentic Prompt Studio project list.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The meta wrapper was still shrinkable, so once its columns became fixed
they overflowed the box and overlapped the action icons (26px at 1440,
66px at 1024). Pin the wrapper too and let the left column, which
ellipsizes, absorb the shortfall.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Frontend Lint Report (Biome)

All checks passed! No linting or formatting issues found.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

List view metadata columns now preserve fixed sizing during resizing, while adapter titles use a semibold font weight.

Changes

List View Styling

Layer / File(s) Summary
Metadata layout and title styling
frontend/src/components/widgets/list-view/ListView.css
The metadata section no longer shrinks, profile and modified containers receive fixed flex bases, and adapter list titles use font-weight: 600.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: kirtimanmishrazipstack

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the CSS fix for aligning owner and updated columns.
Description check ✅ Passed The description follows the template and includes all required sections with substantive content.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch UN-3741-list-align-followup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@greptile-apps

greptile-apps Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Updates the shared list-row presentation.

  • Pins owner and updated metadata to fixed-width flex columns so they align across rows.
  • Prevents the metadata cluster from shrinking into the action controls.
  • Increases list-title font weight to match the agentic project list.

Confidence Score: 5/5

The PR appears safe to merge with no concrete functional or security failures identified.

The fixed metadata widths fit the current shared ListView layouts, while the shrinkable left column and existing ellipsis behavior absorb reduced space without overlapping the action controls.

Important Files Changed

Filename Overview
frontend/src/components/widgets/list-view/ListView.css Aligns metadata columns with fixed flex bases and strengthens list-title typography; current shared ListView variants retain sufficient space and existing ellipsis behavior.

Reviews (1): Last reviewed commit: "UN-3741 [FIX] Stop the pinned meta colum..." | Re-trigger Greptile

@github-actions

Copy link
Copy Markdown
Contributor

Unstract test results

Per-group results

Status Group Tier Passed Failed Errors Skipped Duration (s)
e2e-api-deployment e2e 3 0 0 0 20.8
e2e-coowners e2e 1 0 0 0 1.4
e2e-etl e2e 1 0 0 0 8.3
e2e-login e2e 2 0 0 0 1.2
e2e-prompt-studio e2e 1 0 0 0 4.6
e2e-smoke e2e 2 0 0 0 1.0
e2e-workflow e2e 1 0 0 0 16.8
unit-sdk1 unit 490 0 0 0 28.4
unit-workers unit 723 0 0 0 52.1
TOTAL 1224 0 0 0 134.8

Critical paths

❌ Regressions (must be zero)

  • adapter-register-llm — Register and validate an LLM adapter.
  • workflow-author — Create a workflow; its source+destination endpoints materialise and are configurable.
  • api-deployment-provision — Deploying a workflow as an API mints a usable key and a resolvable endpoint.
  • api-deployment-auth — Unauthenticated or mis-scoped API-deployment calls are rejected before dispatch.
  • prompt-studio-author — Create a Prompt Studio project and add a prompt to it.
  • connector-register-test — Connector credentials are validated against the live system and stored encrypted.
  • usage-aggregate-read — Per-run token usage aggregates correctly and stays scoped to its organization.

⚠️ Critical paths not yet covered

  • workflow-execution-fan-out — Multi-file workflow execution fans out to file-processing workers and rejoins. (declared coverage: no groups declared)
✅ Covered critical paths
  • auth-login — covered by e2e-login
  • co-owner-manage — covered by e2e-coowners
  • workflow-create-execute — covered by e2e-workflow
  • api-deployment-run — covered by e2e-api-deployment
  • prompt-studio-fetch-response — covered by e2e-prompt-studio
  • pipeline-etl-execute — covered by e2e-etl
  • usage-token-tracking — covered by e2e-api-deployment
  • callback-result-delivery — covered by e2e-api-deployment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants