chore(workers): drop redundant black/isort/flake8 dev deps#2021
chore(workers): drop redundant black/isort/flake8 dev deps#2021jaseemjaskp wants to merge 2 commits into
Conversation
Formatting, import-sorting and linting are handled repo-wide by ruff (configured in root pyproject.toml and run via .pre-commit-config.yaml). The workers dev group still carried black/isort/flake8 plus their dead [tool.black]/[tool.isort] config sections, which ruff fully replaces. Removes the three deps and their config; resyncs uv.lock. Keeps mypy (ruff does not type-check) and pytest/debugpy.
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThe PR consolidates development tooling by removing individual formatter and linter packages ( ChangesDevelopment tooling consolidation
🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
| Filename | Overview |
|---|---|
| workers/pyproject.toml | Removes black/isort/flake8 from dev deps and deletes their stale config sections; adds an inline comment explaining the ruff migration rationale. No runtime or production changes. |
| workers/uv.lock | Drops lock entries for exactly the seven packages removed in pyproject.toml (black, flake8, isort, mccabe, pycodestyle, pyflakes, pytokens); all other entries are unchanged. |
| uv.lock | Unintended regeneration strips upload-time fields from every package entry and downgrades the lock revision from 3 to 1; previously flagged in review — no dependency hashes changed, but the churn is noisy and should be reverted. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
subgraph Before["Before this PR (workers dev deps)"]
B1[black] --> L[Lint / Format]
B2[isort] --> L
B3[flake8] --> L
B4[ruff - repo root] --> L
end
subgraph After["After this PR (workers dev deps)"]
A1[ruff - repo root only] --> L2[Lint / Format / Import Sort]
end
subgraph Kept["Still in workers dev deps"]
K1[mypy] --> TC[Type Checking]
K2[pytest / pytest-asyncio / pytest-mock / pytest-cov] --> T[Testing]
K3[debugpy] --> D[Debugging]
end
Reviews (2): Last reviewed commit: "Commit uv.lock changes" | Re-trigger Greptile
| version = 1 | ||
| revision = 3 | ||
| revision = 1 | ||
| requires-python = "==3.12.*" | ||
|
|
||
| [[package]] |
There was a problem hiding this comment.
Unintended root lock-file regeneration
The root uv.lock has ~4,372 lines of changes not described in the PR: every package entry has its upload-time field stripped and the lock-file revision drops from 3 to 1. No packages or hashes changed, so dependency resolution is not affected, but this indicates the root lock file was accidentally regenerated with a different (older) version of uv. The revision downgrade could cause uv sync to re-bump the revision on the next run for any team member or CI job using a newer uv, creating a noisy churn cycle. It would be cleaner to revert the root uv.lock to its pre-PR state, since the intended change only touches workers/uv.lock.
Prompt To Fix With AI
This is a comment left during a code review.
Path: uv.lock
Line: 1-5
Comment:
**Unintended root lock-file regeneration**
The root `uv.lock` has ~4,372 lines of changes not described in the PR: every package entry has its `upload-time` field stripped and the lock-file `revision` drops from `3` to `1`. No packages or hashes changed, so dependency resolution is not affected, but this indicates the root lock file was accidentally regenerated with a different (older) version of `uv`. The `revision` downgrade could cause `uv sync` to re-bump the revision on the next run for any team member or CI job using a newer `uv`, creating a noisy churn cycle. It would be cleaner to revert the root `uv.lock` to its pre-PR state, since the intended change only touches `workers/uv.lock`.
How can I resolve this? If you propose a fix, please make it concise.
jaseemjaskp
left a comment
There was a problem hiding this comment.
Automated PR review (PR Review Toolkit). This is a pure dependency/lock chore — no application code, types, error-handling, or tests are touched, so the Silent Failure Hunter, Type Design Analyzer, PR Test Analyzer, and Code Simplifier passes have no applicable surface. The substantive review is dependency/lockfile correctness.
Summary
workers/pyproject.tomlandworkers/uv.lock: clean and exactly match the stated intent (drop black/isort/flake8 + their[tool.black]/[tool.isort]config and 7 transitive deps; keep mypy;workers/uv.lockstays atrevision = 3). LGTM.- Root
uv.lock: unintended format downgrade — see inline comment. This is the one blocking item.
135099d to
6a7b793
Compare
|
Fixed. The root |
|
Unstract test resultsPer-group results
Critical paths
|



What
black,isort, andflake8from thedevdependency group inworkers/pyproject.toml.[tool.black]and[tool.isort]config sections.workers/uv.lock(drops black/isort/flake8 and their transitive deps: mccabe, pycodestyle, pyflakes, pytokens).Why
pyproject.toml([tool.ruff.lint]+[tool.ruff.format]) and runs globally via.pre-commit-config.yaml(ruff+ruff-format).I= isort), flake8 plugin rules (ANN/TCH/PYI), and formatting (ruff-format≈ black).[tool.black]/[tool.isort]sections were leftovers from before the ruff migration — redundant install + dead config.How
devgroup and deleted the stale tool sections, then ranuv lock.black/isort/flake8directly (only via pre-commit), so removal is safe.mypy(+ its[tool.mypy]config) since ruff does not type-check, andpytest*/debugpywhich are still needed.Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
Database Migrations
Env Config
Relevant Docs
Related Issues or PRs
Dependencies Versions
black,isort,flake8and transitive depsmccabe,pycodestyle,pyflakes,pytokens.Notes on Testing
uv lockresolves cleanly.Screenshots
Checklist
I have read and understood the Contribution Guidelines.