OTEL instrumentation Support#1218
Merged
Merged
Conversation
… into tracing-intrumentation
…er to support otel config passing
… into tracing-intrumentation
for more information, see https://pre-commit.ci
… into tracing-intrumentation
for more information, see https://pre-commit.ci
… into tracing-intrumentation
for more information, see https://pre-commit.ci
… into tracing-intrumentation
ritwik-g
commented
Apr 4, 2025
ritwik-g
commented
Apr 4, 2025
Signed-off-by: Ritwik G <100672805+ritwik-g@users.noreply.github.com>
ritwik-g
commented
Apr 4, 2025
Signed-off-by: Ritwik G <100672805+ritwik-g@users.noreply.github.com>
Contributor
|
There was a problem hiding this comment.
Copilot reviewed 13 out of 19 changed files in this pull request and generated 1 comment.
Files not reviewed (6)
- docker/dockerfiles/backend.Dockerfile: Language not supported
- docker/dockerfiles/platform.Dockerfile: Language not supported
- docker/dockerfiles/prompt.Dockerfile: Language not supported
- docker/dockerfiles/runner.Dockerfile: Language not supported
- docker/dockerfiles/x2text.Dockerfile: Language not supported
- tools/structure/Dockerfile: Language not supported
|
chandrasekharan-zipstack
approved these changes
Apr 7, 2025
chandrasekharan-zipstack
left a comment
Contributor
There was a problem hiding this comment.
LGTM - @ritwik-g does OSS need these OTEL deps to be installed? Will OSS have tracing too?
muhammad-ali-e
approved these changes
Apr 7, 2025
muhammad-ali-e
left a comment
Contributor
There was a problem hiding this comment.
LGTM overall structure
pk-zipstack
pushed a commit
that referenced
this pull request
Aug 20, 2025
* Added OTEL instrumentation dependencies for tracing * Moved gunicorn to main dependency and removed the version for otel instrumentations * Commit pdm.lock changes * Changed the deploy group from dev to optional * Commit pdm.lock changes * Corrected optional dependencies * Commit pdm.lock changes * Added otel config in all services. Added additional env logic in runner to support otel config passing * Commit pdm.lock changes * Corrected logs and runner * corrected the wrong method name * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * reverted adding the otel ids since it causes errro when isntrumentation not present * fixes * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Added missing dependency for tracing * Commit pdm.lock changes * Trace context support for tool. Added logs with trace id in flask logging helper * Fix line length * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fixed line length * Commit pdm.lock changes * Added version for otel sdk and apis * Apply suggestions from code review Signed-off-by: Ritwik G <100672805+ritwik-g@users.noreply.github.com> * Update tools/structure/src/main.py Signed-off-by: Ritwik G <100672805+ritwik-g@users.noreply.github.com> * Removed instrumentation dependencies * Commit pdm.lock changes * Commit pdm.lock changes --------- Signed-off-by: Ritwik G <100672805+ritwik-g@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
How
Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
Database Migrations
Env Config
Relevant Docs
Related Issues or PRs
Dependencies Versions
Notes on Testing
Screenshots
Checklist
I have read and understood the Contribution Guidelines.