Skip to content

deps: upgrade/migrate react-native-vector-icons#3532

Merged
kaloudis merged 1 commit intoZeusLN:masterfrom
kaloudis:deps-react-native-vector-icons
Jan 15, 2026
Merged

deps: upgrade/migrate react-native-vector-icons#3532
kaloudis merged 1 commit intoZeusLN:masterfrom
kaloudis:deps-react-native-vector-icons

Conversation

@kaloudis
Copy link
Copy Markdown
Contributor

@kaloudis kaloudis commented Jan 13, 2026

Description

While upgrading React Native, we upgraded react-native-elements to v5.0.0-beta1 where react-native-vector-icons was removed in favor of the new, modular packages react-native-elements/react-native-elements#3994

I noticed a deprecation warning in the RN console and updated.

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (CLNRest)
  • Nostr Wallet Connect
  • LndHub

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis added this to the v0.12.2 milestone Jan 13, 2026
@kaloudis kaloudis added Dependencies Pull requests that update a dependency file Deprecation labels Jan 13, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist Bot commented Jan 13, 2026

Summary of Changes

Hello @kaloudis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a deprecation warning by migrating the application's icon library from the single, large react-native-vector-icons package to a more modular approach. This change aligns with updates in react-native-elements and improves build efficiency by only including the specific icon sets required, rather than the entire collection. The migration involves updating package dependencies and adjusting native project configurations for iOS to correctly embed the modular icon fonts.

Highlights

  • Icon Library Migration: The monolithic react-native-vector-icons package has been replaced with modular @react-native-vector-icons packages, specifically adding @react-native-vector-icons/fontawesome.
  • Dependency Updates: The package.json, yarn.lock, and ios/Podfile.lock files have been updated to reflect the new modular icon dependencies and remove the old monolithic package.
  • Xcode Project Configuration: The Xcode project file (project.pbxproj) has been modified to remove the old method of embedding all fonts from react-native-vector-icons and now explicitly includes only the necessary fonts from the new modular packages (Feather, FontAwesome, MaterialIcons).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jan 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly migrates from the monolithic react-native-vector-icons package to the new modular packages, specifically adding @react-native-vector-icons/fontawesome to resolve a deprecation warning. The changes are well-contained and affect dependency management files (package.json, yarn.lock, Podfile.lock) and the iOS project configuration. A key benefit of this change is the removal of numerous unused font files from the Xcode project, which should help in reducing the application's size. The changes appear correct and follow best practices for dependency management in a React Native project. I have not found any issues in the submitted code.

@kaloudis kaloudis marked this pull request as draft January 13, 2026 21:58
@kaloudis kaloudis force-pushed the deps-react-native-vector-icons branch from b155022 to c874e8d Compare January 13, 2026 22:32
@kaloudis kaloudis marked this pull request as ready for review January 13, 2026 22:32
ajaysehwal
ajaysehwal reviewed Jan 14, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ajaysehwal ajaysehwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simulator Screenshot - iPhone 17 Pro - 2026-01-14 at 14 03 10 Simulator Screenshot - iPhone 17 Pro - 2026-01-14 at 14 03 16

@kaloudis kaloudis force-pushed the deps-react-native-vector-icons branch from c874e8d to 1320c64 Compare January 15, 2026 04:50
@kaloudis kaloudis requested a review from ajaysehwal January 15, 2026 04:53
ajaysehwal
ajaysehwal approved these changes Jan 15, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ajaysehwal ajaysehwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@kaloudis kaloudis merged commit 70538ce into ZeusLN:master Jan 15, 2026
4 checks passed
@kaloudis kaloudis deleted the deps-react-native-vector-icons branch January 15, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

@ajaysehwal ajaysehwal ajaysehwal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Dependencies Pull requests that update a dependency file Deprecation

Projects

None yet

Milestone

v0.12.2

Development

Successfully merging this pull request may close these issues.

2 participants

@kaloudis @ajaysehwal