GKE script that allows overrides#3
Merged
Merged
Conversation
because I think these restarts might cause instability, in particular if there's other containers on the node. The purpose is to update+restart immediately after node start.
very lucky that time that it worked because now I always get unready nodes
Collaborator
Author
|
Passing overrides as flags-file now and it works really well. It'll be an exercise for later to convert the main FLAGS into flags-file. |
solsson
pushed a commit
that referenced
this pull request
Mar 4, 2026
…warded providers k3d and lima use port forwarding on macOS, so the gateway's internal IP isn't routable. Use -override-ip to write 127.0.0.1 to /etc/hosts instead. Also applies PR #3 feedback: --cache-artifacts=false and remove redundant rollout wait from validate. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
solsson
pushed a commit
that referenced
this pull request
Mar 4, 2026
…s, fix multipass cache - y-k3s-airgap-download outputs tar path on stdout (status to stderr) - Provisioners use download script output instead of duplicating version/arch/path - k3d image tag derived from y-k3s-install (single source of truth for k3s version) - Remove || echo WARNING fallbacks — fail hard on errors - Fix multipass image cache load: transfer tar as file instead of piping through multipass exec (which truncates large stdin streams) - Clarify kubeconfig cleanup comment (from failed provisions) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO forwarding bash args is a pain, in particular with the
--create-subnetworkflag which results inBad syntax for dict arg: [""]unless the empty string isI just found the quite brilliant https://cloud.google.com/sdk/gcloud/reference/topic/flags-file and I think the whole FLAGS variable should be converted before we merge. I've successfully passed overrides that way.