Repository navigation
[JSC] Inlined Array#sort should keep the comparator call kind for bound functions - #77428
Open
sosukesuzuki wants to merge 1 commit into
Conversation
…ound functions https://bugs.webkit.org/show_bug.cgi?id=327983 Reviewed by NOBODY (OOPS!). When the comparator is a bound function, BoundFunctionCallIntrinsic inlined its target as BoundFunctionCall and dropped ArraySortComparatorCall. An OSR exit inside the target then returned past the sort call instead of restarting it. Keep ArraySortComparatorCall. Test: JSTests/stress/array-sort-inline-osr-exit-in-bound-comparator.js * JSTests/stress/array-sort-inline-osr-exit-in-bound-comparator.js: Added. (shouldBe): (compare): (compareWithBoundArguments): (compareWithTailCall): (useResult): (ignoreResult): (tailCall): (callTailCall): (sortBoundTwice): (sortBoundWithArguments): (sortBoundWithTailCall): * Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::handleIntrinsicCall):
Collaborator
|
EWS run on current version of this PR (hash b23a44b) Details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧪 api-mac
b23a44b
b23a44b