Skip to content

Web Inspector: REGRESSION(?): Graphics: focus is lost when using arrow keys to select a WI.TreeElement out of view - #77423

Open
dcrousso wants to merge 1 commit into
WebKit:mainfrom
dcrousso:eng/327978
Open

dcrousso wants to merge 1 commit into
WebKit:mainfrom
dcrousso:eng/327978

Conversation

@dcrousso

@dcrousso dcrousso commented Oct 18, 2026 •

Copy link
Copy Markdown
Member

0ad7565

Web Inspector: REGRESSION(?): Graphics: focus is lost when using arrow keys to select a `WI.TreeElement` out of view
https://bugs.webkit.org/show_bug.cgi?id=327978

Reviewed by NOBODY (OOPS!).

Reattaching an already attached node to the DOM will remove focus as the first step of attaching is removing.

As such, only `WI.TreeElement` that are not already attached should be inserted back into the DOM.

* Source/WebInspectorUI/UserInterface/Views/TreeOutline.js:
(WI.TreeOutline.prototype._updateVirtualizedElements):
Reverse the order of insertion so that `WI.TreeElement` are inserted before their subsequent sibling `WI.TreeElement`.
Ensure that nested `WI.TreeElement` are inserted into the right parent `WI.TreeElement`.

0ad7565

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ⏳ 🧪 api-mac-debug
⏳ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk3-gcc
✅ 🛠 ios-safer-cpp loading 🧪 mac-AS-debug-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ⏳ 🧪 mac-intel-wk2 ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🛠 mac-safer-cpp ✅ 🛠 playstation
✅ 🛠 tv ✅ 🧪 mac-site-isolation
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

…w keys to select a `WI.TreeElement` out of view

https://bugs.webkit.org/show_bug.cgi?id=327978

Reviewed by NOBODY (OOPS!).

Reattaching an already attached node to the DOM will remove focus as the first step of attaching is removing.

As such, only `WI.TreeElement` that are not already attached should be inserted back into the DOM.

* Source/WebInspectorUI/UserInterface/Views/TreeOutline.js:
(WI.TreeOutline.prototype._updateVirtualizedElements):
Reverse the order of insertion so that `WI.TreeElement` are inserted before their subsequent sibling `WI.TreeElement`.
Ensure that nested `WI.TreeElement` are inserted into the right parent `WI.TreeElement`.
@dcrousso dcrousso self-assigned this Oct 18, 2026
@dcrousso dcrousso added the Web Inspector Bugs related to the WebKit Web Inspector. label Oct 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Web Inspector Bugs related to the WebKit Web Inspector.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants