Skip to content

Web Inspector: Debugger: use the sourceURL for breakpoints if provided - #77416

Open
dcrousso wants to merge 1 commit into
WebKit:mainfrom
dcrousso:eng/327970
Open

dcrousso wants to merge 1 commit into
WebKit:mainfrom
dcrousso:eng/327970

Conversation

@dcrousso

@dcrousso dcrousso commented Oct 18, 2026 •

Copy link
Copy Markdown
Member

7bc1a02

Web Inspector: Debugger: use the `sourceURL` for breakpoints if provided
https://bugs.webkit.org/show_bug.cgi?id=327970

Reviewed by NOBODY (OOPS!).

`InspectorDebuggerAgent::setBreakpointByUrl` matches `sourceURL` before `url`.
The frontend `WI.Script` should reflect that as well.

* Source/WebInspectorUI/UserInterface/Models/Script.js:
(WI.Script.prototype.get contentIdentifier):

* LayoutTests/http/tests/inspector/debugger/breakpoint-source-url.html: Added.
* LayoutTests/http/tests/inspector/debugger/breakpoint-source-url-expected.txt: Added.
* LayoutTests/http/tests/inspector/debugger/resources/breakpoint-source-url-named.js: Added.
* LayoutTests/http/tests/inspector/debugger/resources/breakpoint-source-url-plain.js: Added.

7bc1a02

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ⏳ 🧪 api-mac-debug
loading 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk3-gcc
✅ 🛠 ios-safer-cpp ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-wk2-stress ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ⏳ 🧪 mac-intel-wk2 ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🛠 mac-safer-cpp ✅ 🛠 playstation
✅ 🛠 tv ✅ 🧪 mac-site-isolation
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

https://bugs.webkit.org/show_bug.cgi?id=327970

Reviewed by NOBODY (OOPS!).

`InspectorDebuggerAgent::setBreakpointByUrl` matches `sourceURL` before `url`.
The frontend `WI.Script` should reflect that as well.

* Source/WebInspectorUI/UserInterface/Models/Script.js:
(WI.Script.prototype.get contentIdentifier):

* LayoutTests/http/tests/inspector/debugger/breakpoint-source-url.html: Added.
* LayoutTests/http/tests/inspector/debugger/breakpoint-source-url-expected.txt: Added.
* LayoutTests/http/tests/inspector/debugger/resources/breakpoint-source-url-named.js: Added.
* LayoutTests/http/tests/inspector/debugger/resources/breakpoint-source-url-plain.js: Added.
@dcrousso dcrousso self-assigned this Oct 18, 2026
@dcrousso dcrousso added the Web Inspector Bugs related to the WebKit Web Inspector. label Oct 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Web Inspector Bugs related to the WebKit Web Inspector.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants