Repository navigation
[webkitpy] Keep installed packages local to each worktree - #77411
Open
gerardrecinto wants to merge 1 commit into
Open
gerardrecinto wants to merge 1 commit into
gerardrecinto wants to merge 1 commit into
Conversation
https://bugs.webkit.org/show_bug.cgi?id=326443 Reviewed by NOBODY (OOPS!). Worktrees can register different versions of the same Python packages. Sharing an install directory lets them replace each other's dependencies and repeatedly contend for the installation lock. Restore worktree-local installation directories. This brings back duplicate downloads, but keeps incompatible dependencies separate. It also preserves the existing macOS user-library fallback. Tests: python3.12 Tools/Scripts/test-webkitpy webkitpy.autoinstall_unittest * Tools/Scripts/webkitpy/__init__.py: (_get_main_repo_autoinstall_path): Removed. * Tools/Scripts/webkitpy/autoinstall_unittest.py: Added. (AutoInstallDirectoryTest): Cover the main checkout, separate worktrees, and the macOS fallback directory.
Collaborator
|
EWS run on current version of this PR (hash af023dc) Details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[webkitpy] Keep installed packages local to each worktree
https://bugs.webkit.org/show_bug.cgi?id=326443
Reviewed by NOBODY (OOPS!).
Worktrees can register different versions of the same Python packages.
Sharing an install directory lets them replace each other's dependencies
and repeatedly contend for the installation lock.
Restore worktree-local installation directories. This brings back duplicate
downloads, but keeps incompatible dependencies separate. It also preserves
the existing macOS user-library fallback.
Tests: python3.12 Tools/Scripts/test-webkitpy webkitpy.autoinstall_unittest
(_get_main_repo_autoinstall_path): Removed.
(AutoInstallDirectoryTest): Cover the main checkout, separate worktrees,
and the macOS fallback directory.
Validation: all three tests pass with WebKit's runner and Python 3.11/3.12;
check-webkit-style and git diff --check pass. The new test file passes mypy.
Checking both changed files reports the same three existing type errors
as unchanged main, in the IPv6 connection helper. No browser build was run.
Thanks
Gerard Recinto
af023dc
🛠 playstation