Repository navigation
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 851d97d) Details |
… linking it https://bugs.webkit.org/show_bug.cgi?id=327957 Reviewed by NOBODY (OOPS!). Linking Flite put its 13 libraries in every WebKit process. One voice that WebKit doesn't even use, cmu_time_awb, has over 31,000 symbol relocations against itself, about half of all the symbol bindings the dynamic linker does when a WebKit process starts. Each of those lookups searches the global scope of 168 libraries. Load the Flite libraries and the four voices WebKit uses with dlopen() the first time speech synthesis needs them, and call Flite through the resolved functions. Without Flite at runtime, speech synthesis now offers no voices instead of crashing. A bare WPEWebProcess goes from 34 ms to 22 ms from exec to exit, and from 168 to 154 libraries. * Source/WebCore/platform/GStreamer.cmake: * Source/WebCore/platform/gstreamer/GUniquePtrFlite.h: * Source/WebCore/platform/gstreamer/WebKitFliteSourceGStreamer.cpp: (fliteSymbol): (fliteLibrary): (WebCore::fliteDeleteVoice): (WebCore::fliteDeleteWave): (webkitFliteSrcCreate): (fliteVoices): (ensureFliteVoicesInitialized): (webKitFliteSrcSetUtterance): (WTF::toArray): Deleted.
TingPing
force-pushed
the
pgriffis/flite-dlopen
branch
from
October 17, 2026 21:50
851d97d to
243c31d
Compare
Collaborator
|
EWS run on current version of this PR (hash 243c31d) Details |
TingPing
marked this pull request as ready for review
October 17, 2026 22:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
243c31d
243c31d