Repository navigation
Conversation
Collaborator
|
EWS run on previous version of this PR (hash e455980) Details
|
rr-codes
approved these changes
Oct 17, 2026
Collaborator
iOS Safer C++ Build #60524 (e455980)❌ Found 2 failing files with 3 issues. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming. |
Collaborator
macOS Safer C++ Build #140659 (e455980)❌ Found 1 failing file with 1 issue. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming. |
https://bugs.webkit.org/show_bug.cgi?id=327963 Reviewed by NOBODY (OOPS!). Added LEGACY_NODELETE annotation to various functions in Source/WTF. No new tests since there should be no behavioral changes. * Source/WTF/wtf/BitVector.h: * Source/WTF/wtf/ConcurrentPtrHashSet.h: * Source/WTF/wtf/CurrentThread.h: * Source/WTF/wtf/Int128.h: * Source/WTF/wtf/JSONValues.h: * Source/WTF/wtf/LogChannels.h: * Source/WTF/wtf/MediaTime.h: * Source/WTF/wtf/ParallelHelperPool.h: * Source/WTF/wtf/ParkingLot.cpp: * Source/WTF/wtf/PlainGregorianDateTime.h: * Source/WTF/wtf/Seconds.h: * Source/WTF/wtf/SuspendableWorkQueue.h: * Source/WTF/wtf/Threading.h: * Source/WTF/wtf/TimeWithDynamicClockType.h: * Source/WTF/wtf/TimeZone.h: * Source/WTF/wtf/URL.h: * Source/WTF/wtf/URLHelpers.h: * Source/WTF/wtf/URLParser.cpp: (WTF::isInQueryEncodeSet): * Source/WTF/wtf/URLParser.h: * Source/WTF/wtf/WallTime.h: * Source/WTF/wtf/WorkQueue.h: * Source/WTF/wtf/WorkerPool.h: * Source/WTF/wtf/dragonbox/dragonbox_to_chars.h: * Source/WTF/wtf/dtoa.cpp: (WTF::truncateTrailingZeros): * Source/WTF/wtf/dtoa/double-conversion.h: * Source/WTF/wtf/dtoa/fixed-dtoa.cc: * Source/WTF/wtf/dtoa/strtod.cc: * Source/WTF/wtf/persistence/PersistentDecoder.h: * Source/WTF/wtf/text/AtomStringImpl.cpp: (WTF::UTF16BufferTranslator::equal): (WTF::SubstringTranslator8::equal): (WTF::SubstringTranslator16::equal): (WTF::Latin1BufferTranslator::equal): (WTF::BufferFromStaticDataTranslator::equal): (WTF::StaticStringAtomTranslator::equal): (WTF::StaticStringAtomTranslator::translate): (WTF::AtomStringTableRemovalHashTranslator::equal): * Source/WTF/wtf/text/Base64.h: * Source/WTF/wtf/text/StringBuilder.h: * Source/WTF/wtf/text/StringImpl.h: * Source/WTF/wtf/text/StringView.cpp: (WTF::StringView::GraphemeClusters::Iterator::Impl::operator* const): (WTF::StringView::GraphemeClusters::Iterator::Impl::operator== const): * Source/WTF/wtf/text/StringView.h: * Source/WTF/wtf/text/SymbolImpl.h: * Source/WTF/wtf/text/WTFString.cpp: (WTF::doubleToFloatCheckingOverflow): * Source/WTF/wtf/text/WTFString.h: * Source/WTF/wtf/text/icu/UTextProviderLatin1.cpp: (WTF::textLatin1ContextAwareMoveInPriorContext): (WTF::textLatin1ContextAwareSwitchToPriorContext): * Source/WTF/wtf/text/icu/UTextProviderUTF16.cpp: (WTF::textUTF16ContextAwareMoveInPrimaryContext): (WTF::textUTF16ContextAwareSwitchToPrimaryContext): (WTF::textUTF16ContextAwareMoveInPriorContext): (WTF::textUTF16ContextAwareSwitchToPriorContext): (WTF::uTextUTF16ContextAwareAccess): * Source/WTF/wtf/threads/Signals.cpp: (WTF::toSystemSignal):
rniwa
force-pushed
the
fixB327963-nodelete-wtf
branch
from
October 18, 2026 00:16
e455980 to
4964e4b
Compare
Collaborator
|
EWS run on current version of this PR (hash 4964e4b) Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧪 api-ios
4964e4b
4964e4b