Skip to content

Annotate more WTF functions as NODELETE - #77408

Open
rniwa wants to merge 1 commit into
WebKit:mainfrom
rniwa:fixB327963-nodelete-wtf
Open

rniwa wants to merge 1 commit into
WebKit:mainfrom
rniwa:fixB327963-nodelete-wtf

Conversation

@rniwa

@rniwa rniwa commented Oct 17, 2026 •

Copy link
Copy Markdown
Member

4964e4b

Annotate more WTF functions as NODELETE
https://bugs.webkit.org/show_bug.cgi?id=327963

Reviewed by NOBODY (OOPS!).

Added LEGACY_NODELETE annotation to various functions in Source/WTF.

No new tests since there should be no behavioral changes.

* Source/WTF/wtf/BitVector.h:
* Source/WTF/wtf/ConcurrentPtrHashSet.h:
* Source/WTF/wtf/CurrentThread.h:
* Source/WTF/wtf/Int128.h:
* Source/WTF/wtf/JSONValues.h:
* Source/WTF/wtf/LogChannels.h:
* Source/WTF/wtf/MediaTime.h:
* Source/WTF/wtf/ParallelHelperPool.h:
* Source/WTF/wtf/ParkingLot.cpp:
* Source/WTF/wtf/PlainGregorianDateTime.h:
* Source/WTF/wtf/Seconds.h:
* Source/WTF/wtf/SuspendableWorkQueue.h:
* Source/WTF/wtf/Threading.h:
* Source/WTF/wtf/TimeWithDynamicClockType.h:
* Source/WTF/wtf/TimeZone.h:
* Source/WTF/wtf/URL.h:
* Source/WTF/wtf/URLHelpers.h:
* Source/WTF/wtf/URLParser.cpp:
(WTF::isInQueryEncodeSet):
* Source/WTF/wtf/URLParser.h:
* Source/WTF/wtf/WallTime.h:
* Source/WTF/wtf/WorkQueue.h:
* Source/WTF/wtf/WorkerPool.h:
* Source/WTF/wtf/dragonbox/dragonbox_to_chars.h:
* Source/WTF/wtf/dtoa.cpp:
(WTF::truncateTrailingZeros):
* Source/WTF/wtf/dtoa/double-conversion.h:
* Source/WTF/wtf/dtoa/fixed-dtoa.cc:
* Source/WTF/wtf/dtoa/strtod.cc:
* Source/WTF/wtf/persistence/PersistentDecoder.h:
* Source/WTF/wtf/text/AtomStringImpl.cpp:
(WTF::UTF16BufferTranslator::equal):
(WTF::SubstringTranslator8::equal):
(WTF::SubstringTranslator16::equal):
(WTF::Latin1BufferTranslator::equal):
(WTF::BufferFromStaticDataTranslator::equal):
(WTF::StaticStringAtomTranslator::equal):
(WTF::StaticStringAtomTranslator::translate):
(WTF::AtomStringTableRemovalHashTranslator::equal):
* Source/WTF/wtf/text/Base64.h:
* Source/WTF/wtf/text/StringBuilder.h:
* Source/WTF/wtf/text/StringImpl.h:
* Source/WTF/wtf/text/StringView.cpp:
(WTF::StringView::GraphemeClusters::Iterator::Impl::operator* const):
(WTF::StringView::GraphemeClusters::Iterator::Impl::operator== const):
* Source/WTF/wtf/text/StringView.h:
* Source/WTF/wtf/text/SymbolImpl.h:
* Source/WTF/wtf/text/WTFString.cpp:
(WTF::doubleToFloatCheckingOverflow):
* Source/WTF/wtf/text/WTFString.h:
* Source/WTF/wtf/text/icu/UTextProviderLatin1.cpp:
(WTF::textLatin1ContextAwareMoveInPriorContext):
(WTF::textLatin1ContextAwareSwitchToPriorContext):
* Source/WTF/wtf/text/icu/UTextProviderUTF16.cpp:
(WTF::textUTF16ContextAwareMoveInPrimaryContext):
(WTF::textUTF16ContextAwareSwitchToPrimaryContext):
(WTF::textUTF16ContextAwareMoveInPriorContext):
(WTF::textUTF16ContextAwareSwitchToPriorContext):
(WTF::uTextUTF16ContextAwareAccess):
* Source/WTF/wtf/threads/Signals.cpp:
(WTF::toSystemSignal):

4964e4b

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ⏳ 🛠 ios-apple
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ⏳ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ⏳ 🧪 api-mac-debug ✅ 🧪 jsc-wpe
✅ 🧪 jsc-x86-64 loading 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk3-gcc
✅ 🛠 🧪 jsc-debug-arm64 ✅ 🛠 ios-safer-cpp ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ⏳ 🧪 mac-intel-wk2 ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🛠 mac-safer-cpp ✅ 🛠 playstation
✅ 🛠 tv ✅ 🧪 mac-site-isolation
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@rniwa
rniwa requested a review from a team as a code owner October 17, 2026 21:03
@rniwa rniwa self-assigned this Oct 17, 2026
@rniwa rniwa added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Oct 17, 2026
@webkit-ews-buildbot

Copy link
Copy Markdown
Collaborator

iOS Safer C++ Build #60524 (e455980)

❌ Found 2 failing files with 3 issues. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming.
(cc @rniwa)

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 17, 2026
@webkit-ews-buildbot

Copy link
Copy Markdown
Collaborator

macOS Safer C++ Build #140659 (e455980)

❌ Found 1 failing file with 1 issue. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming.
(cc @rniwa)

https://bugs.webkit.org/show_bug.cgi?id=327963

Reviewed by NOBODY (OOPS!).

Added LEGACY_NODELETE annotation to various functions in Source/WTF.

No new tests since there should be no behavioral changes.

* Source/WTF/wtf/BitVector.h:
* Source/WTF/wtf/ConcurrentPtrHashSet.h:
* Source/WTF/wtf/CurrentThread.h:
* Source/WTF/wtf/Int128.h:
* Source/WTF/wtf/JSONValues.h:
* Source/WTF/wtf/LogChannels.h:
* Source/WTF/wtf/MediaTime.h:
* Source/WTF/wtf/ParallelHelperPool.h:
* Source/WTF/wtf/ParkingLot.cpp:
* Source/WTF/wtf/PlainGregorianDateTime.h:
* Source/WTF/wtf/Seconds.h:
* Source/WTF/wtf/SuspendableWorkQueue.h:
* Source/WTF/wtf/Threading.h:
* Source/WTF/wtf/TimeWithDynamicClockType.h:
* Source/WTF/wtf/TimeZone.h:
* Source/WTF/wtf/URL.h:
* Source/WTF/wtf/URLHelpers.h:
* Source/WTF/wtf/URLParser.cpp:
(WTF::isInQueryEncodeSet):
* Source/WTF/wtf/URLParser.h:
* Source/WTF/wtf/WallTime.h:
* Source/WTF/wtf/WorkQueue.h:
* Source/WTF/wtf/WorkerPool.h:
* Source/WTF/wtf/dragonbox/dragonbox_to_chars.h:
* Source/WTF/wtf/dtoa.cpp:
(WTF::truncateTrailingZeros):
* Source/WTF/wtf/dtoa/double-conversion.h:
* Source/WTF/wtf/dtoa/fixed-dtoa.cc:
* Source/WTF/wtf/dtoa/strtod.cc:
* Source/WTF/wtf/persistence/PersistentDecoder.h:
* Source/WTF/wtf/text/AtomStringImpl.cpp:
(WTF::UTF16BufferTranslator::equal):
(WTF::SubstringTranslator8::equal):
(WTF::SubstringTranslator16::equal):
(WTF::Latin1BufferTranslator::equal):
(WTF::BufferFromStaticDataTranslator::equal):
(WTF::StaticStringAtomTranslator::equal):
(WTF::StaticStringAtomTranslator::translate):
(WTF::AtomStringTableRemovalHashTranslator::equal):
* Source/WTF/wtf/text/Base64.h:
* Source/WTF/wtf/text/StringBuilder.h:
* Source/WTF/wtf/text/StringImpl.h:
* Source/WTF/wtf/text/StringView.cpp:
(WTF::StringView::GraphemeClusters::Iterator::Impl::operator* const):
(WTF::StringView::GraphemeClusters::Iterator::Impl::operator== const):
* Source/WTF/wtf/text/StringView.h:
* Source/WTF/wtf/text/SymbolImpl.h:
* Source/WTF/wtf/text/WTFString.cpp:
(WTF::doubleToFloatCheckingOverflow):
* Source/WTF/wtf/text/WTFString.h:
* Source/WTF/wtf/text/icu/UTextProviderLatin1.cpp:
(WTF::textLatin1ContextAwareMoveInPriorContext):
(WTF::textLatin1ContextAwareSwitchToPriorContext):
* Source/WTF/wtf/text/icu/UTextProviderUTF16.cpp:
(WTF::textUTF16ContextAwareMoveInPrimaryContext):
(WTF::textUTF16ContextAwareSwitchToPrimaryContext):
(WTF::textUTF16ContextAwareMoveInPriorContext):
(WTF::textUTF16ContextAwareSwitchToPriorContext):
(WTF::uTextUTF16ContextAwareAccess):
* Source/WTF/wtf/threads/Signals.cpp:
(WTF::toSystemSignal):
@rniwa rniwa removed the merging-blocked Applied to prevent a change from being merged label Oct 18, 2026
@rniwa
rniwa force-pushed the fixB327963-nodelete-wtf branch from e455980 to 4964e4b Compare October 18, 2026 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Bugs Unclassified bugs are placed in this component until the correct component can be determined.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants