Repository navigation
Cherry-pick 32394 - #77277
Open
aperezdc wants to merge 2 commits into
Open
Cherry-pick 32394#77277aperezdc wants to merge 2 commits into
aperezdc wants to merge 2 commits into
Conversation
…gi?id=327722 [soup] Non-redirect 3xx responses with a Location header assert in SubresourceLoader::didReceiveResponse() https://bugs.webkit.org/show_bug.cgi?id=327722 Reviewed by Carlos Garcia Campos. SubresourceLoader::didReceiveResponse() asserts that a response reaching it is not a redirect the network layer should have followed. It phrased that as "any 3xx other than 304 with a Location header", which also rejects 300, 305 and 306: those are final responses whatever headers they carry, and the soup backend rightly delivers them. Rewrite the assertion in terms of ResourceResponse::isRedirection(), which covers the five redirect statuses the fetch specification defines. NetworkDataTaskSoup::shouldStartHTTPRedirection() had the complementary bug: it followed every 3xx response with a Location header except 300, 304, 305 and 306, so unassigned codes such as 309 or 350 were redirected where fetch treats them as final responses. Use isRedirection() there too. Together these make imported/w3c/web-platform-tests/xhr/send-redirect.htm pass on GTK and WPE, so unskip it. The curl backend carries the same exclusion list and is left for its owners. * LayoutTests/platform/glib/TestExpectations: * Source/WebCore/loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didReceiveResponse): * Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp: (WebKit::shouldStartHTTPRedirection): Canonical link: https://commits.webkit.org/323946@main
…gi?id=286127 [GTK] Serialize the composed tree when writing the PRIMARY selection https://bugs.webkit.org/show_bug.cgi?id=286127 Reviewed by Carlos Garcia Campos. WebEditorClient::updateGlobalSelection() serialized the selection with the default SerializeComposedTree::No, unlike every other selection serializer in the tree, including the GLib copy path in Editor::writeSelectionToPasteboard(). In non-composed mode the traversal cannot reach an end point inside a shadow tree, so a selection that crosses a shadow boundary tripped an assertion in StyledMarkupAccumulator::traverseNodesForSerialization() and produced truncated markup in Release. GTK hit it on every selection change because the PRIMARY selection is rewritten each time; no other port serializes there. Pass SerializeComposedTree::Yes and IgnoreUserSelectNone::Yes, matching the copy path, so the PRIMARY selection carries the same markup as Ctrl+C. * LayoutTests/platform/glib/TestExpectations: * LayoutTests/platform/gtk/TestExpectations: Unskip the six selection shadow-dom tests and the editing test, which pass on GTK Release with assertions. * Source/WebKit/WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp: (WebKit::WebEditorClient::updateGlobalSelection): Canonical link: https://commits.webkit.org/323945@main
Collaborator
|
EWS run on current version of this PR (hash 4ff7db2) Details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4ff7db2
952633b
4ff7db2
🛠 ios🛠 mac🛠 win🛠 ios-sim🛠 mac-AS-debug🧪 win-tests🧪 ios-wk2🧪 api-mac🧪 ios-wk2-wpt🧪 api-mac-debug🧪 jsc-x86-64🧪 api-ios🧪 mac-wk2🧪 mac-AS-debug-wk2🛠 vision🧪 mac-wk2-stress🛠 vision-sim🧪 mac-intel-wk2🧪 vision-wk2🛠 mac-safer-cpp🛠 playstation🛠 tv🧪 mac-site-isolation🛠 watch🛠 watch-sim