Repository navigation
Conversation
Collaborator
|
EWS run on previous version of this PR (hash ea8895f) Details
|
https://bugs.webkit.org/show_bug.cgi?id=327831 rdar://190224649 Reviewed by NOBODY (OOPS!). Make it more self-evident which files are actually shared across ports. All of these are compiled into the iOS build with code of their own, which 309708@main and related changes did not cover. This empties loader/mac and history/mac. SerializedPlatformDataCueMac becomes SerializedPlatformDataCueCocoa, and FrameSelectionCocoa.mm guards its Mac-only part with PLATFORM(MAC) instead of !PLATFORM(IOS_FAMILY). Addresses some of the style nits as well. AudioSampleDataSource.mm drops an unused `using namespace JSC;`, which leaked into SerializedPlatformDataCueCocoa.mm in the CMake build's larger unified bundles and made JSValue ambiguous.
annevk
force-pushed
the
eng/Move-remaining-shared-WebCore-mac-files-to-cocoa
branch
from
October 16, 2026 15:19
ea8895f to
c53e8b9
Compare
Collaborator
|
EWS run on current version of this PR (hash c53e8b9) Details
|
rniwa
approved these changes
Oct 16, 2026
Collaborator
macOS Safer C++ Build #140358 (c53e8b9)❌ Found 1 failing file with 1 issue. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧪 api-mac
c53e8b9
c53e8b9