Skip to content

[WTF] LockAlgorithm's unlockSlow should not assume LockType is one byte - #77271

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
kmiller68:eng/WTF-LockAlgorithm-s-unlockSlow-should-not-assume-LockType-is-one-byte
Oct 16, 2026
Merged

[WTF] LockAlgorithm's unlockSlow should not assume LockType is one byte#77271
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
kmiller68:eng/WTF-LockAlgorithm-s-unlockSlow-should-not-assume-LockType-is-one-byte

Conversation

@kmiller68

@kmiller68 kmiller68 commented Oct 16, 2026 •
edited by webkit-early-warning-system
Loading

Copy link
Copy Markdown
Contributor

2b5d8a2

[WTF] LockAlgorithm's unlockSlow should not assume LockType is one byte
https://bugs.webkit.org/show_bug.cgi?id=327826
rdar://190219540

Reviewed by Marcus Plutowski.

The rest of LockAlgorithm uses LockType directly, do the same in
unlockSlow. Also, add some static_asserts and a std::integral constraint
to LockType as drive by fixes.

Test: Tools/TestWebKitAPI/Tests/WTF/Lock.cpp
Canonical link: https://commits.webkit.org/323977@main

d3105dd

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ⏳ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🧪 api-wpe ⏳ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ⏳ 🧪 api-mac-debug ✅ 🧪 jsc-wpe
✅ 🧪 jsc-x86-64 ⏳ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk3-gcc
✅ 🛠 🧪 jsc-debug-arm64 loading 🛠 ios-safer-cpp ⏳ 🧪 mac-AS-debug-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ⏳ 🧪 mac-intel-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 unsafe-merge ✅ 🧪 vision-wk2 ✅ 🛠 mac-safer-cpp ✅ 🛠 playstation
✅ 🛠 tv ✅ 🧪 mac-site-isolation
  🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@kmiller68 kmiller68 self-assigned this Oct 16, 2026
@kmiller68
kmiller68 requested a review from a team as a code owner October 16, 2026 12:54
@webkit-early-warning-system

webkit-early-warning-system commented Oct 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

EWS run on current version of this PR (hash d3105dd)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ⏳ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🧪 api-wpe ⏳ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ⏳ 🧪 api-mac-debug ✅ 🧪 jsc-wpe
✅ 🧪 jsc-x86-64 ⏳ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk3-gcc
✅ 🛠 🧪 jsc-debug-arm64 loading 🛠 ios-safer-cpp ⏳ 🧪 mac-AS-debug-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ⏳ 🧪 mac-intel-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 unsafe-merge ✅ 🧪 vision-wk2 ✅ 🛠 mac-safer-cpp ✅ 🛠 playstation
✅ 🛠 tv ✅ 🧪 mac-site-isolation
  🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@kmiller68 kmiller68 added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 16, 2026
@kmiller68
[WTF] LockAlgorithm's unlockSlow should not assume LockType is one byte
2b5d8a2 
https://bugs.webkit.org/show_bug.cgi?id=327826
rdar://190219540

Reviewed by Marcus Plutowski.

The rest of LockAlgorithm uses LockType directly, do the same in
unlockSlow. Also, add some static_asserts and a std::integral constraint
to LockType as drive by fixes.

Test: Tools/TestWebKitAPI/Tests/WTF/Lock.cpp
Canonical link: https://commits.webkit.org/323977@main
@webkit-commit-queue
webkit-commit-queue force-pushed the eng/WTF-LockAlgorithm-s-unlockSlow-should-not-assume-LockType-is-one-byte branch from d3105dd to 2b5d8a2 Compare October 16, 2026 16:48
@webkit-commit-queue

webkit-commit-queue commented Oct 16, 2026

Copy link
Copy Markdown
Collaborator

Committed 323977@main (2b5d8a2): https://commits.webkit.org/323977@main

Reviewed commits have been landed. Closing PR #77271 and removing active labels.

@webkit-commit-queue
webkit-commit-queue merged commit 2b5d8a2 into WebKit:main Oct 16, 2026
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Achierius Achierius Achierius approved these changes

Assignees

@kmiller68 kmiller68

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kmiller68 @webkit-early-warning-system @webkit-commit-queue @Achierius