Instagram.com: story circle borders are black instead of colorful.#62320
Open
mattwoodrow wants to merge 1 commit intoWebKit:mainfrom
Open
Instagram.com: story circle borders are black instead of colorful.#62320mattwoodrow wants to merge 1 commit intoWebKit:mainfrom
mattwoodrow wants to merge 1 commit intoWebKit:mainfrom
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 37d00b9) Details
|
🧪 api-mac
smfr
approved these changes
Apr 9, 2026
https://bugs.webkit.org/show_bug.cgi?id=311780 <rdar://173536875> Reviewed by NOBODY (OOPS!). Stroked arcs with a gradient fill aren't being rendered correctly. Fall back to strokePath if there's a gradient fill, since that requires special handling outside of CG. Match strokePath's behaviour for pattern fills, and explicitly apply it. Tests: imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.strokeStyle.gradient.arc-ref.html imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.strokeStyle.gradient.arc.html imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.strokeStyle.pattern.arc-ref.html imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.strokeStyle.pattern.arc.html * LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.strokeStyle.gradient.arc-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.strokeStyle.gradient.arc-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.strokeStyle.gradient.arc.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.strokeStyle.pattern.arc-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.strokeStyle.pattern.arc-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.strokeStyle.pattern.arc.html: Added. * Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContextCG::strokeArc):
37d00b9 to
60bbef0
Compare
Collaborator
|
EWS run on current version of this PR (hash 60bbef0) Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
60bbef0
60bbef0