[WTF] Make UTF-8 StringImpl::create defensive against concurrent content modification#62311
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Apr 9, 2026
Conversation
Collaborator
|
EWS run on previous version of this PR (hash edca997) Details
|
edca997 to
8f70071
Compare
Collaborator
|
EWS run on previous version of this PR (hash 8f70071) Details
|
8f70071 to
5a68384
Compare
Collaborator
|
EWS run on current version of this PR (hash 5a68384) Details |
sosukesuzuki
approved these changes
Apr 9, 2026
…ent modification https://bugs.webkit.org/show_bug.cgi?id=311771 rdar://173601233 Reviewed by Mark Lam and Sosuke Suzuki. It seems that some of JSC clients are using StringImpl::create wrongly, and modifying the passed content concurrently. Previously, it was a bit gracefully handled without SIMDUTF, but new code requires this invariant more strictly and getting release-assert when this is broken. Modifying concurrently is not allowed and that's a client bug, but anyway, let's make it a bit defensive against such a behavior. This patch uses pre-allocated maximally-possible sized Vector and using simdutf::convert_utf8_to_utf16 instead. * Source/WTF/wtf/text/StringImpl.cpp: (WTF::StringImpl::create): Canonical link: https://commits.webkit.org/310857@main
5a68384 to
83b6ec3
Compare
Collaborator
|
Committed 310857@main (83b6ec3): https://commits.webkit.org/310857@main Reviewed commits have been landed. Closing PR #62311 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧪 bindings
83b6ec3
5a68384