Add hit test support for HTMLModelElement#62310
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Apr 15, 2026
Merged
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 040e526) Details
|
etiennesegonzac
approved these changes
Apr 10, 2026
| { | ||
| #if ENABLE(MODEL_ELEMENT) | ||
| if (RefPtr element = dynamicDowncast<HTMLModelElement>(m_innerNonSharedNode.get())) | ||
| return element->currentSrc(); |
Contributor
There was a problem hiding this comment.
looks like other URLs in this file are passed through applyLinkDecorationFiltering first
040e526 to
ef0a334
Compare
Collaborator
|
EWS run on current version of this PR (hash ef0a334) Details
|
https://bugs.webkit.org/show_bug.cgi?id=311768 rdar://173910796 Reviewed by Etienne Segonzac. Add hit test support for HTMLModelElement so browsers can download the usdz files. * Source/WebCore/rendering/HitTestResult.cpp: (WebCore::HitTestResult::absoluteMediaURL const): (WebCore::HitTestResult::absoluteModelURL const): * Source/WebCore/rendering/HitTestResult.h: * Source/WebKit/Shared/API/Cocoa/_WKHitTestResult.h: * Source/WebKit/Shared/API/Cocoa/_WKHitTestResult.mm: (-[_WKHitTestResult absoluteModelURL]): * Source/WebKit/Shared/Cocoa/InteractionInformationAtPosition.h: * Source/WebKit/Shared/Cocoa/InteractionInformationAtPosition.mm: (WebKit::InteractionInformationAtPosition::InteractionInformationAtPosition): * Source/WebKit/Shared/Cocoa/InteractionInformationAtPosition.serialization.in: * Source/WebKit/Shared/WebHitTestResultData.cpp: (WebKit::WebHitTestResultData::WebHitTestResultData): * Source/WebKit/Shared/WebHitTestResultData.h: * Source/WebKit/Shared/WebHitTestResultData.serialization.in: * Source/WebKit/UIProcess/API/APIHitTestResult.h: (API::HitTestResult::absoluteModelURL const): * Source/WebKit/UIProcess/API/Cocoa/_WKActivatedElementInfo.h: * Source/WebKit/UIProcess/API/Cocoa/_WKActivatedElementInfo.mm: (-[_WKActivatedElementInfo _initWithInteractionInformationAtPosition:isUsingAlternateURLForImage:userInfo:]): (-[_WKActivatedElementInfo modelURL]): * Source/WebKit/WebProcess/WebPage/Cocoa/PositionInformationForWebPage.mm: (WebKit::positionInformationForWebPage): Canonical link: https://commits.webkit.org/311320@main
ef0a334 to
b481551
Compare
Collaborator
|
Committed 311320@main (b481551): https://commits.webkit.org/311320@main Reviewed commits have been landed. Closing PR #62310 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b481551
ef0a334
🧪 win-tests🧪 ios-wk2-wpt