Unprefix -webkit-user-select by AlexsanderDamaceno · Pull Request #38619 · WebKit/WebKit

AlexsanderDamaceno · 2025-01-07T03:51:14Z

`f7a9411`

Unprefix -webkit-user-select
https://bugs.webkit.org/show_bug.cgi?id=208677

Reviewed by NOBODY (OOPS!).

Unprefix -webkit-user-select and make it an alias for user-select.

* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/user-select-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/user-select-computed-expected.txt:
* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle const):
* Source/WebCore/dom/ImageOverlay.cpp:
(WebCore::ImageOverlay::updateSubtree):
(WebCore::ImageOverlay::updateWithTextRecognitionResult):
* LayoutTests/editing/selection/user-select-js-property-expected.txt:
* LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt:
* LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-ui/inheritance-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/user-select-valid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-ui/user-select-inheritance-expected.txt:
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* LayoutTests/svg/css/getComputedStyle-basic-expected.txt:

f7a9411

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	🧪 api-gtk
	✅ 🧪 vision-wk2	❌ 🧪 mac-intel-wk2	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2025-01-07T03:51:22Z

EWS run on previous version of this PR (hash 15921cd)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 win-tests~~
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	~~🧪 api-wpe~~
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	❌ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	❌ 🧪 mac-wk2-stress	~~🧪 api-gtk~~
	~~🧪 vision-wk2~~	❌ 🧪 mac-intel-wk2	~~🛠 playstation~~
	✅ 🛠 tv	~~🛠 mac-safer-cpp~~
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

rniwa · 2025-01-07T03:54:52Z

This should be moved to between CSSPropertyPage and CSSPropertyScrollMargin.

user-select should be discretely animatable fwiw: https://drafts.csswg.org/css-ui/#content-selection

rniwa · 2025-01-07T03:56:23Z

Hm... this behavior discrepancy is a bit concerning. We should figure out if we can fix this before unprefixing the property.

I agree, we should try to fix it first. I started here, but never got around to finishing it: #36579

@nt1m you would like to finish it? or could I try modify the pr ?

As this fail happens with the prefixed property, could we not work on unprefix this first and after work on this missing parameter?

Feel free to take over the PR if you wish.

As this fail happens with the prefixed property, could we not work on unprefix this first and after work on this missing parameter?

I tried a first time, and I had to revert because of bug 242006 wasn't fixed, and that broke outlook.

webkit-early-warning-system · 2025-01-07T04:18:36Z

EWS run on previous version of this PR (hash 8fa57c0)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	❌ 🧪 win-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	❌ 🧪 mac-intel-wk2	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

https://bugs.webkit.org/show_bug.cgi?id=208677 Reviewed by NOBODY (OOPS!). Unprefix -webkit-user-select and make it an alias for user-select. * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/user-select-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/user-select-computed-expected.txt: * Source/WebCore/animation/CSSPropertyAnimation.cpp: (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): * Source/WebCore/css/CSSProperties.json: * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyInStyle const): * Source/WebCore/dom/ImageOverlay.cpp: (WebCore::ImageOverlay::updateSubtree): (WebCore::ImageOverlay::updateWithTextRecognitionResult): * LayoutTests/editing/selection/user-select-js-property-expected.txt: * LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt: * LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-ui/inheritance-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/user-select-valid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-ui/user-select-inheritance-expected.txt: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/svg/css/getComputedStyle-basic-expected.txt:

webkit-early-warning-system · 2025-01-07T17:52:11Z

EWS run on current version of this PR (hash f7a9411)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	🧪 api-gtk
	✅ 🧪 vision-wk2	❌ 🧪 mac-intel-wk2	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

AlexsanderDamaceno requested review from cdumez, graouts and rniwa as code owners January 7, 2025 03:51

AlexsanderDamaceno self-assigned this Jan 7, 2025

AlexsanderDamaceno added the CSS Cascading Style Sheets implementation label Jan 7, 2025

AlexsanderDamaceno removed request for cdumez, graouts and rniwa January 7, 2025 03:51

rniwa reviewed Jan 7, 2025

View reviewed changes

AlexsanderDamaceno force-pushed the unprefix-webkit-user-select branch from 15921cd to 8fa57c0 Compare January 7, 2025 04:18

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 7, 2025

AlexsanderDamaceno removed the merging-blocked Applied to prevent a change from being merged label Jan 7, 2025

AlexsanderDamaceno force-pushed the unprefix-webkit-user-select branch from 8fa57c0 to f7a9411 Compare January 7, 2025 17:52

AlexsanderDamaceno requested a review from brentfulgham January 7, 2025 18:11

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 7, 2025

o-t-w mentioned this pull request Sep 4, 2025

unprefix the -webkit-user-select CSS property web-platform-tests/interop#1000

Closed

surajt6 mentioned this pull request Feb 27, 2026

Implement auto value as a computed value for user-select and stop making it inherited #36579

Closed

Navigation Menu

Repository navigation

Unprefix -webkit-user-select - #38619

Unprefix -webkit-user-select#38619
AlexsanderDamaceno wants to merge 1 commit into
WebKit:mainfrom
AlexsanderDamaceno:unprefix-webkit-user-select

AlexsanderDamaceno commented Jan 7, 2025 •

edited by webkit-early-warning-system

Loading

Uh oh!

webkit-early-warning-system commented Jan 7, 2025 •

edited

Loading

Uh oh!

rniwa Jan 7, 2025

Uh oh!

nt1m Jan 7, 2025

Uh oh!

rniwa Jan 7, 2025

Uh oh!

nt1m Jan 7, 2025

Uh oh!

AlexsanderDamaceno Jan 7, 2025

Uh oh!

AlexsanderDamaceno Jan 7, 2025

Uh oh!

nt1m Jan 7, 2025

Uh oh!

webkit-early-warning-system commented Jan 7, 2025 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Jan 7, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

AlexsanderDamaceno commented Jan 7, 2025 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Jan 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

webkit-early-warning-system commented Jan 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Jan 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

AlexsanderDamaceno commented Jan 7, 2025 •

edited by webkit-early-warning-system

Loading

webkit-early-warning-system commented Jan 7, 2025 •

edited

Loading

webkit-early-warning-system commented Jan 7, 2025 •

edited

Loading

webkit-early-warning-system commented Jan 7, 2025 •

edited

Loading